From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27332 invoked by alias); 28 Jun 2012 13:18:31 -0000 Received: (qmail 27315 invoked by uid 22791); 28 Jun 2012 13:18:29 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jun 2012 13:18:09 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5SDI8fD007213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Jun 2012 09:18:08 -0400 Received: from spoyarek (vpn-234-46.phx2.redhat.com [10.3.234.46]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5SDI5PW029757; Thu, 28 Jun 2012 09:18:06 -0400 Date: Thu, 28 Jun 2012 13:18:00 -0000 From: Siddhesh Poyarekar To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Tom Tromey , Sergio Durigan Subject: Splint report and scripts for gdb (was: Expand bitpos and type.length) Message-ID: <20120628184814.30a8977f@spoyarek> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00851.txt.bz2 Hi Jan, I'm breaking this out into a new thread since I'm finding it difficult to search for responses in the old thread due to the huge amount of nesting. The old thread is here: http://sourceware.org/ml/gdb-patches/2012-06/msg00635.html I started trying to reduce the splint report further, again with a newer approach. We're essentially looking for splint warnings that are present after applying the bitpos patch, including those that were newly generated and were relevant to the bitpos change, so the old output sections (The '-' lines) are unnecessary in the report. Based on this, I did the following: * Modified splint-locdiff script to remove all unnecessary lines like 'finished checking', etc. The change is small enough that one can see the changes straight away. * Removed all the '-' lines, so that what we get is only the report of warnings generated after bitpos. After all the sanitization, what we have left is a very clean pattern, which is: LOC (file:num) The warning for this LOC I used this to evaluate if the assignments, function parameters, etc. for each of those warnings were size-compatible, i.e. they won't result in truncation, and passed those. I don't look at sign preservation across the patch any more because it is easier to do that from the patch rather than the splint output. Along with this, I have tried to make the output of the final script as compact as possible without losing readability. The result is a final output of 666 lines. I have uploaded the tarball here: http://siddhesh.fedorapeople.org/splint-bitpos.tar.xz These are the exact same files that you had uploaded earlier, so you should be able to git-init a repository from your files and then overwrite them with my copy to get a difference. Can you please review the script changes? Thanks, Siddhesh