Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>,
	Kai Tietz <ktietz70@googlemail.com>,
	Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFA] Add Windows x64 SEH unwinder
Date: Wed, 20 Jun 2012 14:48:00 -0000	[thread overview]
Message-ID: <20120620144756.GB2799@adacore.com> (raw)
In-Reply-To: <8A4BC294-364D-4D09-8C24-B492A9340C9D@adacore.com>

> 2012-06-15  Tristan Gingold  <gingold@adacore.com>
> 
> 	* amd64-windows-tdep.c (struct x64_frame_cache): Declare.
> 	(x64_w2gdb_regnum): New array.
> 	(x64_frame_decode_epilogue,	x64_frame_decode_insns)
> 	(x64_frame_cache, x64_frame_prev_register, x64_frame_this_id): New
> 	functions.
> 	(x64_frame_unwind): New variable.
> 	(amd64_windows_init_abi): Register this unwinder.
> 	* NEWS: Mention it.

Just for the record, Tristan and I found a weakness in this approach
which causes regressions for leaf functions when the compiler is not
configured to produce native SEH info (IIUC). My understanding is that,
the problem is that there is no entry for a function if the function
is a leaf function. So, for the case of such function, we don't know
if there is no info because it is a leaf function, or because it wasn't
going to be provided in the first place.

We discussed this situation, and Tristan proposed to make the DWARF
unwinder take priority over the native SEH info. I think that's
a good idea, in any case.

I also see that Tristan made some changes in our tree today, providing
a prologue-skipping routine, but I think that this is for a different
issue (I haven't had a chance to talk to him yet).

-- 
Joel


      parent reply	other threads:[~2012-06-20 14:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15  8:10 Tristan Gingold
2012-06-15 18:06 ` Joel Brobecker
2012-06-18  9:23   ` Tristan Gingold
2012-06-16 10:40 ` Mark Kettenis
2012-06-18  9:18   ` Tristan Gingold
2012-06-18 16:12     ` Eli Zaretskii
2012-06-20 14:48     ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620144756.GB2799@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    --cc=ktietz70@googlemail.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox