From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5392 invoked by alias); 20 Jun 2012 14:48:15 -0000 Received: (qmail 5383 invoked by uid 22791); 20 Jun 2012 14:48:14 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jun 2012 14:48:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7DB6A1C736F; Wed, 20 Jun 2012 10:48:00 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rLTsFICUccA0; Wed, 20 Jun 2012 10:48:00 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AD0E11C7229; Wed, 20 Jun 2012 10:47:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 13330145616; Wed, 20 Jun 2012 07:47:56 -0700 (PDT) Date: Wed, 20 Jun 2012 14:48:00 -0000 From: Joel Brobecker To: Tristan Gingold Cc: "gdb-patches@sourceware.org ml" , Kai Tietz , Mark Kettenis Subject: Re: [RFA] Add Windows x64 SEH unwinder Message-ID: <20120620144756.GB2799@adacore.com> References: <201206161039.q5GAdfST016307@glazunov.sibelius.xs4all.nl> <8A4BC294-364D-4D09-8C24-B492A9340C9D@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8A4BC294-364D-4D09-8C24-B492A9340C9D@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00633.txt.bz2 > 2012-06-15 Tristan Gingold > > * amd64-windows-tdep.c (struct x64_frame_cache): Declare. > (x64_w2gdb_regnum): New array. > (x64_frame_decode_epilogue, x64_frame_decode_insns) > (x64_frame_cache, x64_frame_prev_register, x64_frame_this_id): New > functions. > (x64_frame_unwind): New variable. > (amd64_windows_init_abi): Register this unwinder. > * NEWS: Mention it. Just for the record, Tristan and I found a weakness in this approach which causes regressions for leaf functions when the compiler is not configured to produce native SEH info (IIUC). My understanding is that, the problem is that there is no entry for a function if the function is a leaf function. So, for the case of such function, we don't know if there is no info because it is a leaf function, or because it wasn't going to be provided in the first place. We discussed this situation, and Tristan proposed to make the DWARF unwinder take priority over the native SEH info. I think that's a good idea, in any case. I also see that Tristan made some changes in our tree today, providing a prologue-skipping routine, but I think that this is for a different issue (I haven't had a chance to talk to him yet). -- Joel