From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix inline frame crash in handle_inferior_event
Date: Wed, 13 Jun 2012 06:56:00 -0000 [thread overview]
Message-ID: <20120613065545.GB11317@host2.jankratochvil.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1206121703180.23962@tp.orcam.me.uk>
On Wed, 13 Jun 2012 07:12:54 +0200, Maciej W. Rozycki wrote:
> 2012-06-13 Maciej W. Rozycki <macro@codesourcery.com>
>
> gdb/
> * infrun.c (handle_inferior_event): Re-fetch frame and gdbarch
> after hiding inline functions.
This is PR backtrace/13866.
> --- gdb-fsf-trunk-quilt.orig/gdb/infrun.c 2012-06-08 23:45:43.000000000 +0100
> +++ gdb-fsf-trunk-quilt/gdb/infrun.c 2012-06-12 08:29:31.063547656 +0100
> @@ -4084,7 +4084,13 @@ handle_inferior_event (struct execution_
> && pc_at_non_inline_function (aspace,
> ecs->event_thread->prev_pc,
> &ecs->ws)))
> - skip_inline_frames (ecs->ptid);
> + {
> + skip_inline_frames (ecs->ptid);
Empty line before comment.
> + /* Re-fetch current thread's frame in case that invalidated
> + the frame cache. */
> + frame = get_current_frame ();
> + gdbarch = get_frame_arch (frame);
> + }
> }
>
> if (ecs->event_thread->suspend.stop_signal == GDB_SIGNAL_TRAP
Yes, fine with me.
Thanks,
Jan
next prev parent reply other threads:[~2012-06-13 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 5:13 Maciej W. Rozycki
2012-06-13 6:56 ` Jan Kratochvil [this message]
2012-06-14 21:16 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613065545.GB11317@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox