From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16260 invoked by alias); 13 Jun 2012 06:56:06 -0000 Received: (qmail 16252 invoked by uid 22791); 13 Jun 2012 06:56:05 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 06:55:53 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5D6tn7t017585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jun 2012 02:55:50 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5D6tjUV003602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 13 Jun 2012 02:55:48 -0400 Date: Wed, 13 Jun 2012 06:56:00 -0000 From: Jan Kratochvil To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix inline frame crash in handle_inferior_event Message-ID: <20120613065545.GB11317@host2.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00387.txt.bz2 On Wed, 13 Jun 2012 07:12:54 +0200, Maciej W. Rozycki wrote: > 2012-06-13 Maciej W. Rozycki > > gdb/ > * infrun.c (handle_inferior_event): Re-fetch frame and gdbarch > after hiding inline functions. This is PR backtrace/13866. > --- gdb-fsf-trunk-quilt.orig/gdb/infrun.c 2012-06-08 23:45:43.000000000 +0100 > +++ gdb-fsf-trunk-quilt/gdb/infrun.c 2012-06-12 08:29:31.063547656 +0100 > @@ -4084,7 +4084,13 @@ handle_inferior_event (struct execution_ > && pc_at_non_inline_function (aspace, > ecs->event_thread->prev_pc, > &ecs->ws))) > - skip_inline_frames (ecs->ptid); > + { > + skip_inline_frames (ecs->ptid); Empty line before comment. > + /* Re-fetch current thread's frame in case that invalidated > + the frame cache. */ > + frame = get_current_frame (); > + gdbarch = get_frame_arch (frame); > + } > } > > if (ecs->event_thread->suspend.stop_signal == GDB_SIGNAL_TRAP Yes, fine with me. Thanks, Jan