Re: [RFA] Add support for --enable-lmcheck configure option.

[Joel Brobecker <brobecker@adacore.com>]

> this is bloating the configure script + configure help.  Just use:
> 	LDFLAGS=-lmcheck ./configure ...
> 
> 
> > I don't think I'll personally use the --disable-libmcheck on a snapshot,
> > but someone distributing a snaphot version might enjoy it too.
> 
> Yes:
> 	http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-disable-mcheck.patch;hb=master
> 
> But I do not find it so important to make a configure option to it.

I read your answer as: "I do not object, but I don't think it is useful".
Therefore, I would like to keep the patch on the table and see if there
are objections. Otherwise, I'd like to commit it, because I think it is
going to be useful.

> Given that --disable-libmcheck for snapshot may make some sense I do not
> oppose it but I do not think it is worth it, it is a corner case where one can
> edit configure or Makefile IMO.

I don't want people to have to modify the sources or maintain such
a modification in their sources. I think that this is unfriendly,
especially given the small size of the patch. Saying that is is
bloating (sic) the configure script and help is a little extreme,
if you ask me.

> I understand the reason is to workaround current GDB bugs exposed by -lmcheck.
> This is sure not the right solution.

This is absolutely wrong. Maybe some people might want to use it that
way, but that is not my goal. It seemed easy to assume that, but that
is not the case. I think it is a very valuable addition for developers,
and I just fixed one buffer overflow thanks to it yesterday. And I expect
that all AdaCore developers will be building GDB with -lmcheck, even
the release versions.

-- 
Joel