From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4145 invoked by alias); 12 Jun 2012 16:55:51 -0000 Received: (qmail 4135 invoked by uid 22791); 12 Jun 2012 16:55:49 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO,TW_BM X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jun 2012 16:55:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 03A3A1C6A90; Tue, 12 Jun 2012 12:55:35 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id x8-SVD1pB7d0; Tue, 12 Jun 2012 12:55:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C008D1C61E7; Tue, 12 Jun 2012 12:55:34 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1F152145616; Tue, 12 Jun 2012 09:55:23 -0700 (PDT) Date: Tue, 12 Jun 2012 16:55:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Add support for --enable-lmcheck configure option. Message-ID: <20120612165523.GR2687@adacore.com> References: <1339447127-314-1-git-send-email-brobecker@adacore.com> <20120612074215.GB4374@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120612074215.GB4374@host2.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00365.txt.bz2 > this is bloating the configure script + configure help. Just use: > LDFLAGS=-lmcheck ./configure ... > > > > I don't think I'll personally use the --disable-libmcheck on a snapshot, > > but someone distributing a snaphot version might enjoy it too. > > Yes: > http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-disable-mcheck.patch;hb=master > > But I do not find it so important to make a configure option to it. I read your answer as: "I do not object, but I don't think it is useful". Therefore, I would like to keep the patch on the table and see if there are objections. Otherwise, I'd like to commit it, because I think it is going to be useful. > Given that --disable-libmcheck for snapshot may make some sense I do not > oppose it but I do not think it is worth it, it is a corner case where one can > edit configure or Makefile IMO. I don't want people to have to modify the sources or maintain such a modification in their sources. I think that this is unfriendly, especially given the small size of the patch. Saying that is is bloating (sic) the configure script and help is a little extreme, if you ask me. > I understand the reason is to workaround current GDB bugs exposed by -lmcheck. > This is sure not the right solution. This is absolutely wrong. Maybe some people might want to use it that way, but that is not my goal. It seemed easy to assume that, but that is not the case. I think it is a very valuable addition for developers, and I just fixed one buffer overflow thanks to it yesterday. And I expect that all AdaCore developers will be building GDB with -lmcheck, even the release versions. -- Joel