From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/2] gdbarch_gdb_signal_from_target: Mention host independence.
Date: Mon, 04 Jun 2012 16:26:00 -0000 [thread overview]
Message-ID: <20120604162550.11635.93929.stgit@brno.lan> (raw)
In-Reply-To: <4FCCD900.3040102@redhat.com>
Applied.
2012-06-04 Pedro Alves <palves@redhat.com>
* gdbarch.sh (gdb_signal_from_target): Mention that the
implementation of the method must be host independent.
* gdbarch.h: Regenerate.
---
gdb/gdbarch.h | 11 +++++++----
gdb/gdbarch.sh | 11 +++++++----
2 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 5d73d72..da449c2 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -940,10 +940,13 @@ extern int gdbarch_process_record_signal (struct gdbarch *gdbarch, struct regcac
extern void set_gdbarch_process_record_signal (struct gdbarch *gdbarch, gdbarch_process_record_signal_ftype *process_record_signal);
/* Signal translation: translate inferior's signal (target's) number
- into GDB's representation. This is mainly used when cross-debugging
- core files --- "Live" targets hide the translation behind the target
- interface (target_wait, target_resume, etc.). The default is to do
- the translation using host signal numbers. */
+ into GDB's representation. The implementation of this method must
+ be host independent. IOW, don't rely on symbols of the NAT_FILE
+ header (the nm-*.h files), the host <signal.h> header, or similar
+ headers. This is mainly used when cross-debugging core files ---
+ "Live" targets hide the translation behind the target interface
+ (target_wait, target_resume, etc.). The default is to do the
+ translation using host signal numbers. */
typedef enum gdb_signal (gdbarch_gdb_signal_from_target_ftype) (struct gdbarch *gdbarch, int signo);
extern enum gdb_signal gdbarch_gdb_signal_from_target (struct gdbarch *gdbarch, int signo);
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index cc1fe65..5cefdab 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -773,10 +773,13 @@ M:int:process_record:struct regcache *regcache, CORE_ADDR addr:regcache, addr
M:int:process_record_signal:struct regcache *regcache, enum gdb_signal signal:regcache, signal
# Signal translation: translate inferior's signal (target's) number
-# into GDB's representation. This is mainly used when cross-debugging
-# core files --- "Live" targets hide the translation behind the target
-# interface (target_wait, target_resume, etc.). The default is to do
-# the translation using host signal numbers.
+# into GDB's representation. The implementation of this method must
+# be host independent. IOW, don't rely on symbols of the NAT_FILE
+# header (the nm-*.h files), the host <signal.h> header, or similar
+# headers. This is mainly used when cross-debugging core files ---
+# "Live" targets hide the translation behind the target interface
+# (target_wait, target_resume, etc.). The default is to do the
+# translation using host signal numbers.
m:enum gdb_signal:gdb_signal_from_target:int signo:signo::default_gdb_signal_from_target::0
# Extra signal info inspection.
next prev parent reply other threads:[~2012-06-04 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 20:21 [PATCH] MIPS Linux signals Michael Eager
2012-06-01 20:53 ` Maciej W. Rozycki
2012-06-01 21:07 ` Michael Eager
2012-06-04 15:49 ` Pedro Alves
2012-06-04 16:26 ` Pedro Alves [this message]
2012-06-04 16:26 ` [PATCH 2/2] Make gdbarch_gdb_signal_from_target a method with predicate Pedro Alves
2012-06-01 22:52 ` [PATCH] MIPS Linux signals Michael Eager
2012-06-06 22:52 ` Maciej W. Rozycki
2012-06-06 23:12 ` Michael Eager
2012-06-11 16:09 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604162550.11635.93929.stgit@brno.lan \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox