From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32766 invoked by alias); 4 Jun 2012 16:26:23 -0000 Received: (qmail 32725 invoked by uid 22791); 4 Jun 2012 16:26:16 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 16:25:54 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q54GPqSM008587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Jun 2012 12:25:52 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q54GPpfQ001555 for ; Mon, 4 Jun 2012 12:25:51 -0400 Subject: [PATCH 1/2] gdbarch_gdb_signal_from_target: Mention host independence. To: gdb-patches@sourceware.org From: Pedro Alves Date: Mon, 04 Jun 2012 16:26:00 -0000 Message-ID: <20120604162550.11635.93929.stgit@brno.lan> In-Reply-To: <4FCCD900.3040102@redhat.com> References: <4FCCD900.3040102@redhat.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00084.txt.bz2 Applied. 2012-06-04 Pedro Alves * gdbarch.sh (gdb_signal_from_target): Mention that the implementation of the method must be host independent. * gdbarch.h: Regenerate. --- gdb/gdbarch.h | 11 +++++++---- gdb/gdbarch.sh | 11 +++++++---- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 5d73d72..da449c2 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -940,10 +940,13 @@ extern int gdbarch_process_record_signal (struct gdbarch *gdbarch, struct regcac extern void set_gdbarch_process_record_signal (struct gdbarch *gdbarch, gdbarch_process_record_signal_ftype *process_record_signal); /* Signal translation: translate inferior's signal (target's) number - into GDB's representation. This is mainly used when cross-debugging - core files --- "Live" targets hide the translation behind the target - interface (target_wait, target_resume, etc.). The default is to do - the translation using host signal numbers. */ + into GDB's representation. The implementation of this method must + be host independent. IOW, don't rely on symbols of the NAT_FILE + header (the nm-*.h files), the host header, or similar + headers. This is mainly used when cross-debugging core files --- + "Live" targets hide the translation behind the target interface + (target_wait, target_resume, etc.). The default is to do the + translation using host signal numbers. */ typedef enum gdb_signal (gdbarch_gdb_signal_from_target_ftype) (struct gdbarch *gdbarch, int signo); extern enum gdb_signal gdbarch_gdb_signal_from_target (struct gdbarch *gdbarch, int signo); diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index cc1fe65..5cefdab 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -773,10 +773,13 @@ M:int:process_record:struct regcache *regcache, CORE_ADDR addr:regcache, addr M:int:process_record_signal:struct regcache *regcache, enum gdb_signal signal:regcache, signal # Signal translation: translate inferior's signal (target's) number -# into GDB's representation. This is mainly used when cross-debugging -# core files --- "Live" targets hide the translation behind the target -# interface (target_wait, target_resume, etc.). The default is to do -# the translation using host signal numbers. +# into GDB's representation. The implementation of this method must +# be host independent. IOW, don't rely on symbols of the NAT_FILE +# header (the nm-*.h files), the host header, or similar +# headers. This is mainly used when cross-debugging core files --- +# "Live" targets hide the translation behind the target interface +# (target_wait, target_resume, etc.). The default is to do the +# translation using host signal numbers. m:enum gdb_signal:gdb_signal_from_target:int signo:signo::default_gdb_signal_from_target::0 # Extra signal info inspection.