From: Joel Brobecker <brobecker@adacore.com>
To: "H.J. Lu" <hongjiu.lu@intel.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Set size of long/ptr as well as sp/pc for x32
Date: Mon, 14 May 2012 18:11:00 -0000 [thread overview]
Message-ID: <20120514181113.GN10253@adacore.com> (raw)
In-Reply-To: <20120514180146.GA18462@intel.com>
> {
> + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
> amd64_linux_init_abi (info, gdbarch, tdesc_x32_linux,
I cannot approve the patch, but I noticed that you forgot to add
an empty line after the last local variable declaration.
--
Joel
next prev parent reply other threads:[~2012-05-14 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 18:02 H.J. Lu
2012-05-14 18:11 ` Joel Brobecker [this message]
2012-05-14 18:16 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514181113.GN10253@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hongjiu.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox