From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11374 invoked by alias); 14 May 2012 18:11:36 -0000 Received: (qmail 11366 invoked by uid 22791); 14 May 2012 18:11:34 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 May 2012 18:11:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CCCA11C6ED1; Mon, 14 May 2012 14:11:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id h-EOOZZNmwnT; Mon, 14 May 2012 14:11:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9BE671C6ECA; Mon, 14 May 2012 14:11:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 77A05145616; Mon, 14 May 2012 11:11:13 -0700 (PDT) Date: Mon, 14 May 2012 18:11:00 -0000 From: Joel Brobecker To: "H.J. Lu" Cc: GDB Subject: Re: PATCH: Set size of long/ptr as well as sp/pc for x32 Message-ID: <20120514181113.GN10253@adacore.com> References: <20120514180146.GA18462@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120514180146.GA18462@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00532.txt.bz2 > { > + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); > amd64_linux_init_abi (info, gdbarch, tdesc_x32_linux, I cannot approve the patch, but I noticed that you forgot to add an empty line after the last local variable declaration. -- Joel