From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>,
Kaushik Phatak <Kaushik.Phatak@kpitcummins.com>,
"Jayant R. Sonar" <Jayant.Sonar@kpitcummins.com>,
Prafulla Thakare <Prafulla.Thakare@kpitcummins.com>
Subject: Re: [Patch] CR16 Simulator fix for gdb 7.4
Date: Sun, 13 May 2012 19:06:00 -0000 [thread overview]
Message-ID: <201205131506.13396.vapier@gentoo.org> (raw)
In-Reply-To: <87sjf8p0by.fsf@fleche.redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 752 bytes --]
On Thursday 10 May 2012 10:39:13 Tom Tromey wrote:
> >>>>> "Kaushik" == Kaushik Phatak <Kaushik.Phatak@kpitcummins.com> writes:
> Kaushik> I am not able to figure out the reason why the attached hunk
> Kaushik> (nltvals.def) has been removed from the sources, maybe
> Kaushik> regenerate missed it out.
>
> I don't think this patch is ok as-is.
> The top of nltvals.def says:
>
> /* This file is machine generated by gennltvals.sh. */
>
> So, I think the bug must either be in gennltvals.sh, or in one of its
> input files, and the proper way to fix this would be to find the
> original bug, fix it, and re-run gennltvals.sh.
correct, this patch is wrong. please see:
http://sourceware.org/bugzilla/show_bug.cgi?id=12862
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-13 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 14:24 Kaushik Phatak
2012-05-10 14:39 ` Tom Tromey
2012-05-13 19:06 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205131506.13396.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=Jayant.Sonar@kpitcummins.com \
--cc=Kaushik.Phatak@kpitcummins.com \
--cc=Prafulla.Thakare@kpitcummins.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox