From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6855 invoked by alias); 13 May 2012 19:06:01 -0000 Received: (qmail 6846 invoked by uid 22791); 13 May 2012 19:06:00 -0000 X-SWARE-Spam-Status: No, hits=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 13 May 2012 19:05:47 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7B4A31B403F; Sun, 13 May 2012 19:05:46 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [Patch] CR16 Simulator fix for gdb 7.4 Date: Sun, 13 May 2012 19:06:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.4.0-rc6; KDE/4.6.5; x86_64; ; ) Cc: Tom Tromey , Kaushik Phatak , "Jayant R. Sonar" , Prafulla Thakare References: <87sjf8p0by.fsf@fleche.redhat.com> In-Reply-To: <87sjf8p0by.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1366057.ZLKRxYD1NS"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201205131506.13396.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00494.txt.bz2 --nextPart1366057.ZLKRxYD1NS Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 748 On Thursday 10 May 2012 10:39:13 Tom Tromey wrote: > >>>>> "Kaushik" =3D=3D Kaushik Phatak wr= ites: > Kaushik> I am not able to figure out the reason why the attached hunk > Kaushik> (nltvals.def) has been removed from the sources, maybe > Kaushik> regenerate missed it out. >=20 > I don't think this patch is ok as-is. > The top of nltvals.def says: >=20 > /* This file is machine generated by gennltvals.sh. */ >=20 > So, I think the bug must either be in gennltvals.sh, or in one of its > input files, and the proper way to fix this would be to find the > original bug, fix it, and re-run gennltvals.sh. correct, this patch is wrong. please see: http://sourceware.org/bugzilla/show_bug.cgi?id=3D12862 -mike --nextPart1366057.ZLKRxYD1NS Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPsAYlAAoJEEFjO5/oN/WBd3IQAIJhXewUEb2JDf3/hEULZCxL GyE8u8HwBfLXSGY02Aewo4cmxNC7GN/bzmBR1lU60oB6BSMs/1K/J0hMG1qUEc3g M0bSdYrzYffGG0zH41l8fwpdwCSry0+7Z6C7vWgRKgpWk+2U7B2u/yL8o2NIIAq6 W2+hb1ILrA6jjRl1omUWIxT05N19LfW/AcX/IGpp+EDE5jTwi33SP6fOw+D/0iC0 yNr813LYFTSypRU8ig9i4W+7MXU0LF6/UqtekyOrk9BrAa2vF8eHXK01dML1lgTn ddDZS/98dpOHUSMZsrknUytd6AP/G6PENyuzgCtQHm2w5/A7P1xJyK5pY885Jrvm V7m/JIHa7PUVCGCbEtxaTecb12BpoUiPbjwsKPVCSND0AdaIniJ+tFNLMg87L30W py41mzus7H+H5cHXChPfh/R2EM9vd55XbPGiQPtPlXubpYy9cbAIjpmmKOZ9YC4t pj4H1t4Q4UbYylEIafy8KajjonYnvTd9OtcUhaYxgCwg9Sm8AI1Ppu04EGGyrjt9 TqG6ZMpz3ngf2ApyFljIwMP1nDkcSNf9m4mIVxJGRmPwLrAvciI0CH6Ezuww5fhr DPSkCDeyAnHGgkoDdXwc67rUwZy10mi4IX9BmKeEHdgAY05Dmu0TjA4Mafw1ohr2 xujOtJ0EUCDTZcLdPAO8 =dVNv -----END PGP SIGNATURE----- --nextPart1366057.ZLKRxYD1NS--