From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: joel.sherrill@oarcorp.com
Cc: gdb-patches@sourceware.org
Subject: Re: Microblaze simulator - Fix missing prototype
Date: Tue, 08 May 2012 13:37:00 -0000 [thread overview]
Message-ID: <201205081337.q48Db5m3011814@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4FA91C76.1090108@oarcorp.com> (message from Joel Sherrill on Tue, 8 May 2012 08:15:34 -0500)
> Date: Tue, 8 May 2012 08:15:34 -0500
> From: Joel Sherrill <joel.sherrill@oarcorp.com>
>
> Without this patch, the Microblaze simulator generates
> a missing prototype warning which is treated as an error.
> I don't see this routine referenced elsewhere, so there is
> the possibility that it also could be made static. But
> it definitely needs a prototype to build.
>
> OK to apply?
Eh, mismatch between ChangeLog entry and actual diff?
> 2012-05-12 Joel Sherrill <joel.sherrill@oarcorp.com>
>
> * microblaze-rom.c (_initialize_picobug_rom): Add prototype.
>
> Index: gdb/configure.tgt
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.tgt,v
> retrieving revision 1.253
> diff -u -r1.253 configure.tgt
> --- gdb/configure.tgt 24 Apr 2012 03:33:16 -0000 1.253
> +++ gdb/configure.tgt 7 May 2012 20:15:54 -0000
> @@ -331,8 +331,8 @@
> monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o"
> gdb_sim=../sim/microblaze/libsim.a
> ;;
> -microblaze*-*-*)
> - # Target: Xilinx MicroBlaze running standalone
> +microblaze*-*-* | microblaze*-*-rtems*)
> + # Target: Xilinx MicroBlaze running standalone (or RTEMS)
> gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
> gdb_sim=../sim/microblaze/libsim.a
> ;;
next prev parent reply other threads:[~2012-05-08 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 13:16 Joel Sherrill
2012-05-08 13:37 ` Mark Kettenis [this message]
2012-05-08 13:53 ` Sergio Durigan Junior
2012-05-15 13:30 ` Michael Eager
[not found] <4FA82F46.4080901@oarcorp.com>
2012-05-08 5:21 ` Sergio Durigan Junior
2012-05-08 14:07 ` Joel Sherrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205081337.q48Db5m3011814@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=joel.sherrill@oarcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox