From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90778-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22444 invoked by alias); 8 May 2012 13:37:28 -0000
Received: (qmail 22388 invoked by uid 22791); 8 May 2012 13:37:27 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,TW_YM,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 May 2012 13:37:10 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q48Db648000847;	Tue, 8 May 2012 15:37:06 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q48Db5m3011814;	Tue, 8 May 2012 15:37:05 +0200 (CEST)
Date: Tue, 08 May 2012 13:37:00 -0000
Message-Id: <201205081337.q48Db5m3011814@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: joel.sherrill@oarcorp.com
CC: gdb-patches@sourceware.org
In-reply-to: <4FA91C76.1090108@oarcorp.com> (message from Joel Sherrill on	Tue, 8 May 2012 08:15:34 -0500)
Subject: Re: Microblaze simulator - Fix missing prototype
References:  <4FA91C76.1090108@oarcorp.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00220.txt.bz2

> Date: Tue, 8 May 2012 08:15:34 -0500
> From: Joel Sherrill <joel.sherrill@oarcorp.com>
> 
> Without this patch, the Microblaze simulator generates
> a missing prototype warning which is treated as an error.
> I don't see this routine referenced elsewhere, so there is
> the possibility that it also could be made static.  But
> it definitely needs a prototype to build.
> 
> OK to apply?

Eh, mismatch between ChangeLog entry and actual diff?

> 2012-05-12  Joel Sherrill <joel.sherrill@oarcorp.com>
> 
>      * microblaze-rom.c (_initialize_picobug_rom): Add prototype.
> 
> Index: gdb/configure.tgt
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.tgt,v
> retrieving revision 1.253
> diff -u -r1.253 configure.tgt
> --- gdb/configure.tgt	24 Apr 2012 03:33:16 -0000	1.253
> +++ gdb/configure.tgt	7 May 2012 20:15:54 -0000
> @@ -331,8 +331,8 @@
>  			monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o"
>  	gdb_sim=../sim/microblaze/libsim.a
>  	;;
> -microblaze*-*-*)
> -	# Target: Xilinx MicroBlaze running standalone
> +microblaze*-*-* | microblaze*-*-rtems*)
> +	# Target: Xilinx MicroBlaze running standalone (or RTEMS)
>  	gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
>  	gdb_sim=../sim/microblaze/libsim.a
>  	;;