Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* New ARI warning Sat Apr 28 01:55:01 UTC 2012
@ 2012-04-28  4:24 GDB Administrator
  2012-04-28  4:31 ` Sergio Durigan Junior
  0 siblings, 1 reply; 4+ messages in thread
From: GDB Administrator @ 2012-04-28  4:24 UTC (permalink / raw)
  To: gdb-patches

617a618
> gdb/probe.c:273: gettext: _ markup: All messages should be marked up with _.
gdb/probe.c:273:      error ("%s: %s", message, err);


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Sat Apr 28 01:55:01 UTC 2012
  2012-04-28  4:24 New ARI warning Sat Apr 28 01:55:01 UTC 2012 GDB Administrator
@ 2012-04-28  4:31 ` Sergio Durigan Junior
  2012-04-28  4:37   ` Joel Brobecker
  0 siblings, 1 reply; 4+ messages in thread
From: Sergio Durigan Junior @ 2012-04-28  4:31 UTC (permalink / raw)
  To: GDB Administrator; +Cc: gdb-patches

On Friday, April 27 2012, GDB Administrator wrote:

> 617a618
>> gdb/probe.c:273: gettext: _ markup: All messages should be marked up with _.
> gdb/probe.c:273:      error ("%s: %s", message, err);

Well, this was actually a request by Jan, who correctly said that
internationalization in this string is useless.  I can obviously provide
a trivial patch for that, and I know it's the easiest solution for this,
but I'd like to know if there isn't any other way of filtering such
obvious non-internationalized cases.

Thanks,

-- 
Sergio


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Sat Apr 28 01:55:01 UTC 2012
  2012-04-28  4:31 ` Sergio Durigan Junior
@ 2012-04-28  4:37   ` Joel Brobecker
  2012-04-28  4:54     ` Sergio Durigan Junior
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2012-04-28  4:37 UTC (permalink / raw)
  To: Sergio Durigan Junior; +Cc: gdb-patches

> Well, this was actually a request by Jan, who correctly said that
> internationalization in this string is useless.  I can obviously provide
> a trivial patch for that, and I know it's the easiest solution for this,
> but I'd like to know if there isn't any other way of filtering such
> obvious non-internationalized cases.

I think you just place the string inside parenthesis, like so:

        error (("%s"), message);

-- 
Joel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Sat Apr 28 01:55:01 UTC 2012
  2012-04-28  4:37   ` Joel Brobecker
@ 2012-04-28  4:54     ` Sergio Durigan Junior
  0 siblings, 0 replies; 4+ messages in thread
From: Sergio Durigan Junior @ 2012-04-28  4:54 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

On Saturday, April 28 2012, Joel Brobecker wrote:

>> Well, this was actually a request by Jan, who correctly said that
>> internationalization in this string is useless.  I can obviously provide
>> a trivial patch for that, and I know it's the easiest solution for this,
>> but I'd like to know if there isn't any other way of filtering such
>> obvious non-internationalized cases.
>
> I think you just place the string inside parenthesis, like so:
>
>         error (("%s"), message);

Hm, ok, I thought the ARI script would look for the `_' char, but in
that case, I will apply a patch and commit it right away.

Thanks,

-- 
Sergio


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-04-28  4:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-28  4:24 New ARI warning Sat Apr 28 01:55:01 UTC 2012 GDB Administrator
2012-04-28  4:31 ` Sergio Durigan Junior
2012-04-28  4:37   ` Joel Brobecker
2012-04-28  4:54     ` Sergio Durigan Junior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox