Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: davem@davemloft.net
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix complex float handling for 64-bit SPARC
Date: Sun, 08 Apr 2012 05:59:00 -0000	[thread overview]
Message-ID: <201204080558.q385wZSq026406@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20120407.164726.2225800511552785327.davem@davemloft.net>	(message from David Miller on Sat, 07 Apr 2012 16:47:26 -0400 (EDT))

> Date: Sat, 07 Apr 2012 16:47:26 -0400 (EDT)
> From: David Miller <davem@davemloft.net>
> 
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> Date: Sat, 7 Apr 2012 22:17:40 +0200 (CEST)
> 
> > Looks like the 64-bit code you committed last year wasn't complete.
> > There is a missing sparc64_complex_float_p() check, which results in a
> > guarenteed assertion failure.  The diff below fixes this and as a
> > bonus also makes complex return values work.  Makes the complex float
> > tests in gdb.base/callfuncs.exp work with the OpenBSD system compiler
> > (GCC 4.2.1).  As far as I can tell this matches what's documented in
> > the Sun Studio 12 Fortran Programming Guide.
> > 
> > ok?
> 
> Looks good to me, thanks.

Thanks,

Committed


      reply	other threads:[~2012-04-08  5:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07 20:18 Mark Kettenis
2012-04-07 20:47 ` David Miller
2012-04-08  5:59   ` Mark Kettenis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204080558.q385wZSq026406@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=davem@davemloft.net \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox