From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3940 invoked by alias); 8 Apr 2012 05:59:11 -0000 Received: (qmail 3931 invoked by uid 22791); 8 Apr 2012 05:59:10 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 08 Apr 2012 05:58:47 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q385wcdi010215; Sun, 8 Apr 2012 07:58:38 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q385wZSq026406; Sun, 8 Apr 2012 07:58:35 +0200 (CEST) Date: Sun, 08 Apr 2012 05:59:00 -0000 Message-Id: <201204080558.q385wZSq026406@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: davem@davemloft.net CC: gdb-patches@sourceware.org In-reply-to: <20120407.164726.2225800511552785327.davem@davemloft.net> (message from David Miller on Sat, 07 Apr 2012 16:47:26 -0400 (EDT)) Subject: Re: [PATCH] Fix complex float handling for 64-bit SPARC References: <201204072017.q37KHeYH010978@glazunov.sibelius.xs4all.nl> <20120407.164726.2225800511552785327.davem@davemloft.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00123.txt.bz2 > Date: Sat, 07 Apr 2012 16:47:26 -0400 (EDT) > From: David Miller > > From: Mark Kettenis > Date: Sat, 7 Apr 2012 22:17:40 +0200 (CEST) > > > Looks like the 64-bit code you committed last year wasn't complete. > > There is a missing sparc64_complex_float_p() check, which results in a > > guarenteed assertion failure. The diff below fixes this and as a > > bonus also makes complex return values work. Makes the complex float > > tests in gdb.base/callfuncs.exp work with the OpenBSD system compiler > > (GCC 4.2.1). As far as I can tell this matches what's documented in > > the Sun Studio 12 Fortran Programming Guide. > > > > ok? > > Looks good to me, thanks. Thanks, Committed