Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [SH] gdb.asm/asm-source.exp
Date: Fri, 23 Mar 2012 03:56:00 -0000	[thread overview]
Message-ID: <20120322205559.06a99bad@mesquite.lan> (raw)
In-Reply-To: <87ty1gedqk.fsf@schwinge.name>

Hi Thomas,

On Thu, 22 Mar 2012 18:40:03 +0100
Thomas Schwinge <thomas_schwinge@mentor.com> wrote:

> gdb/testsuite/
> 
> 	* gdb.asm/sh.inc (gdbasm_end) <.size>: Refer to the function's name.
[...]
> gdb/testsuite/
> 
> 	* gdb.asm/sh.inc (gdbasm_startup): Only set up the stack pointer if the
> 	symbol _stack is defined.  Get rid of a hard-coded constant for _stack.
[...]
> 
> OK to commit both patches?

I'm not an expert on this stuff, but your patches look reasonable to
me.  Please wait a few days for objections and, if none are
forthcoming, check it in.

Kevin


      reply	other threads:[~2012-03-23  3:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 17:40 Thomas Schwinge
2012-03-23  3:56 ` Kevin Buettner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120322205559.06a99bad@mesquite.lan \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox