From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31545 invoked by alias); 23 Mar 2012 03:56:30 -0000 Received: (qmail 31529 invoked by uid 22791); 23 Mar 2012 03:56:29 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Mar 2012 03:56:01 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2N3u1X5011813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 22 Mar 2012 23:56:01 -0400 Received: from mesquite.lan (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2N3u0Q5030160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 22 Mar 2012 23:56:01 -0400 Date: Fri, 23 Mar 2012 03:56:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [SH] gdb.asm/asm-source.exp Message-ID: <20120322205559.06a99bad@mesquite.lan> In-Reply-To: <87ty1gedqk.fsf@schwinge.name> References: <87ty1gedqk.fsf@schwinge.name> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00795.txt.bz2 Hi Thomas, On Thu, 22 Mar 2012 18:40:03 +0100 Thomas Schwinge wrote: > gdb/testsuite/ > > * gdb.asm/sh.inc (gdbasm_end) <.size>: Refer to the function's name. [...] > gdb/testsuite/ > > * gdb.asm/sh.inc (gdbasm_startup): Only set up the stack pointer if the > symbol _stack is defined. Get rid of a hard-coded constant for _stack. [...] > > OK to commit both patches? I'm not an expert on this stuff, but your patches look reasonable to me. Please wait a few days for objections and, if none are forthcoming, check it in. Kevin