From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: gdb-patches@sourceware.org
Subject: Re: Please fix regressions from your sim changes
Date: Tue, 20 Mar 2012 16:30:00 -0000 [thread overview]
Message-ID: <201203201630.q2KGUAp7020158@ignucius.se.axis.com> (raw)
In-Reply-To: <201203201215.57048.vapier@gentoo.org> (message from Mike Frysinger on Tue, 20 Mar 2012 17:15:55 +0100)
> From: Mike Frysinger <vapier@gentoo.org>
> Date: Tue, 20 Mar 2012 17:15:55 +0100
> On Tuesday 20 March 2012 01:54:27 Hans-Peter Nilsson wrote:
> > nrun.o -MMD -MP -MF .deps/nrun.Tpo /tmp/r/sim/cris/../common/nrun.c
> > /tmp/r/sim/cris/../common/nrun.c: In function 'main':
> > /tmp/r/sim/cris/../common/nrun.c:206: warning: implicit declaration of
> > function 'strsignal' /tmp/r/sim/cris/../common/nrun.c:206: warning: format
> > '%s' expects type 'char *', but argument 4 has type 'int'
> > Don't you see that warning?
>
> the code compiles warning free for me
> the file should have a string.h include for the strsignal prototype, so i'll update that.
>
> > Instead, to #define _GNU_SOURCE in the Right Way AFAIK, there
> > should be an AC_GNU_SOURCE (missing) in a configure.* used by
> > all src/sim/* (common/configure.ac AFAICT), and an #include
> > "cconfig.h" in nrun.c followed later by the mantra:
>
> not entirely the right way. my guess is that your older glibc does not
> conform to the newer POSIX spec. strsignal() was added in the 2008 spec, but
> old glibc's provided it only when _GNU_SOURCE was defined.
It's be the right way to maintain interoperability even with old
systems not-fully-conformant-in-every-corner that *used* to
work, if there's a known way, like here, that doesn't introduce
a maintenance burden.
Please.
brgds, H-P
next prev parent reply other threads:[~2012-03-20 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:29 Hans-Peter Nilsson
2012-03-19 17:23 ` Mike Frysinger
2012-03-19 23:51 ` Hans-Peter Nilsson
2012-03-20 2:30 ` Mike Frysinger
2012-03-20 5:55 ` Hans-Peter Nilsson
2012-03-20 16:16 ` Mike Frysinger
2012-03-20 16:30 ` Hans-Peter Nilsson [this message]
2012-03-23 4:23 ` Mike Frysinger
2012-03-21 4:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203201630.q2KGUAp7020158@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox