From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24031 invoked by alias); 20 Mar 2012 16:30:31 -0000 Received: (qmail 23922 invoked by uid 22791); 20 Mar 2012 16:30:29 -0000 X-SWARE-Spam-Status: No, hits=0.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD,URIBL_BLACK X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Mar 2012 16:30:14 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id 7E85F19DF6 for ; Tue, 20 Mar 2012 17:30:11 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4pXbLJ7qiZWC for ; Tue, 20 Mar 2012 17:30:11 +0100 (CET) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by anubis.se.axis.com (Postfix) with ESMTP id 04A6D19DAC for ; Tue, 20 Mar 2012 17:30:11 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id 02CF33E0B8; Tue, 20 Mar 2012 17:30:11 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id q2KGUAF6020162; Tue, 20 Mar 2012 17:30:10 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id q2KGUAp7020158; Tue, 20 Mar 2012 17:30:10 +0100 Date: Tue, 20 Mar 2012 16:30:00 -0000 Message-Id: <201203201630.q2KGUAp7020158@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gdb-patches@sourceware.org In-reply-to: <201203201215.57048.vapier@gentoo.org> (message from Mike Frysinger on Tue, 20 Mar 2012 17:15:55 +0100) Subject: Re: Please fix regressions from your sim changes MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00745.txt.bz2 > From: Mike Frysinger > Date: Tue, 20 Mar 2012 17:15:55 +0100 > On Tuesday 20 March 2012 01:54:27 Hans-Peter Nilsson wrote: > > nrun.o -MMD -MP -MF .deps/nrun.Tpo /tmp/r/sim/cris/../common/nrun.c > > /tmp/r/sim/cris/../common/nrun.c: In function 'main': > > /tmp/r/sim/cris/../common/nrun.c:206: warning: implicit declaration of > > function 'strsignal' /tmp/r/sim/cris/../common/nrun.c:206: warning: format > > '%s' expects type 'char *', but argument 4 has type 'int' > > Don't you see that warning? > > the code compiles warning free for me > the file should have a string.h include for the strsignal prototype, so i'll update that. > > > Instead, to #define _GNU_SOURCE in the Right Way AFAIK, there > > should be an AC_GNU_SOURCE (missing) in a configure.* used by > > all src/sim/* (common/configure.ac AFAICT), and an #include > > "cconfig.h" in nrun.c followed later by the mantra: > > not entirely the right way. my guess is that your older glibc does not > conform to the newer POSIX spec. strsignal() was added in the 2008 spec, but > old glibc's provided it only when _GNU_SOURCE was defined. It's be the right way to maintain interoperability even with old systems not-fully-conformant-in-every-corner that *used* to work, if there's a known way, like here, that doesn't introduce a maintenance burden. Please. brgds, H-P