Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
	gdb-patches@sourceware.org,        Eli Zaretskii <eliz@gnu.org>,
	Mark Wielaard <mark@klomp.org>
Subject: Re: [RFA take 6] Allow setting breakpoints on inline functions (PR	10738)
Date: Thu, 15 Mar 2012 10:51:00 -0000	[thread overview]
Message-ID: <20120315105117.GA3076@redhat.com> (raw)
In-Reply-To: <CADPb22S8992GZdoP7x_o897bWhrzS5Cz9_agM_ThVRXpEDm3bA@mail.gmail.com>

Doug Evans wrote:
> On Wed, Mar 14, 2012 at 10:54 AM, Jan Kratochvil
> <jan.kratochvil@redhat.com> wrote:
> > On Wed, 14 Mar 2012 18:50:55 +0100, Doug Evans wrote:
> > > +  --use-old-index-sections\n\
> > > +                     Do not reject old (broken) .gdb_index sections.\n\
> > > +"), stream);
> > >
> > > s/(broken)/(incomplete)/
> >
> > FYI I may not have the right interpretation of English words but
> > with "incomplete" it may suggest to me that only part of the file
> > will use index and part of the file will be processed by a slower
> > non-indexed method.
> >
> > It should suggest user the GDB functionality will be affected.
> 
> The doc patch uses the word "incomplete", so that's why I suggest
> using it here.  If one wants to find a better word, great, but I
> think the same word should be used in both places.

Jan, Doug, Eli, how do you feel about "possibly inconsistent"?

The option text would become:

"Do not reject possibly inconsistent .gdb_index sections."

and the docs would be s/incomplete/possibly inconsistent/

Warnings would be:
  versions < 4: "Skipping obsolete .gdb-index section in %s"
  versions 4,5: "Skipping possibly inconsistent .gdb_index section in %s,
                 pass --use-old-index-sections to use them anyway"

Does that look ok?

Thanks,
Gary

--
http://gbenson.net/


  reply	other threads:[~2012-03-15 10:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 13:38 Gary Benson
2012-03-14 17:51 ` Doug Evans
2012-03-14 17:55   ` Jan Kratochvil
2012-03-14 17:58     ` Doug Evans
2012-03-15 10:51       ` Gary Benson [this message]
2012-03-15 10:52         ` Jan Kratochvil
2012-03-15 16:51         ` Doug Evans
2012-03-15 18:04         ` Eli Zaretskii
2012-03-15 18:10           ` Gary Benson
2012-03-15 18:15             ` Eli Zaretskii
2012-03-15 18:26               ` Gary Benson
2012-03-15 18:31               ` Pedro Alves
2012-03-15 18:36                 ` Eli Zaretskii
2012-03-15 18:40                   ` Jan Kratochvil
2012-03-15 19:29                     ` Gary Benson
2012-03-15 19:34                       ` Doug Evans
2012-03-15 19:52                         ` Pedro Alves
2012-03-15 20:06                           ` Pedro Alves
2012-03-16 10:03                             ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315105117.GA3076@redhat.com \
    --to=gbenson@redhat.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox