Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Problem after hitting breakpoint on Windows (with GDBserver)
Date: Tue, 13 Mar 2012 14:24:00 -0000	[thread overview]
Message-ID: <20120313142418.GA29255@host2.jankratochvil.net> (raw)
In-Reply-To: <1331602756-23567-1-git-send-email-brobecker@adacore.com>

On Tue, 13 Mar 2012 02:39:15 +0100, Joel Brobecker wrote:
>     One way to fix that problem was to lift that limitation, by using
>     a temporary buffer inside memory_xfer_partial, and then copy the
>     contents of that buffer into the target buffer after the two steps
>     are complete. But Pedro felt it was too heavy a hammer.

This problem was affecting also gdbserver which I fixed in December:
	[patch] gdbserver: Fix overlapping memcpy (safe now)
	http://sourceware.org/ml/gdb-patches/2011-12/msg00057.html

I tried now shortly and I cannot reproduce the valgrind errors for GDB with
gdbserver with disabled z* packets but according to the code and according to
you description it looks as the same problem.

Isn't it safer to fix all the cases?


Thanks,
Jan


  parent reply	other threads:[~2012-03-13 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13  1:39 Joel Brobecker
2012-03-13  1:39 ` [RFA] " Joel Brobecker
2012-03-13 15:03   ` Pedro Alves
2012-03-13 22:00     ` Joel Brobecker
2012-03-13 23:08       ` Pedro Alves
2012-03-14 21:50         ` Joel Brobecker
2012-03-15  1:04           ` Joel Brobecker
2012-03-15 10:35             ` Pedro Alves
2012-03-15 18:36               ` Joel Brobecker
2012-03-13 14:24 ` Jan Kratochvil [this message]
2012-03-13 14:52   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313142418.GA29255@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox