From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27202 invoked by alias); 13 Mar 2012 14:24:48 -0000 Received: (qmail 27193 invoked by uid 22791); 13 Mar 2012 14:24:47 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Mar 2012 14:24:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2DEOMrU006638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Mar 2012 10:24:22 -0400 Received: from host2.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2DEOI4s026042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 13 Mar 2012 10:24:21 -0400 Date: Tue, 13 Mar 2012 14:24:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: Problem after hitting breakpoint on Windows (with GDBserver) Message-ID: <20120313142418.GA29255@host2.jankratochvil.net> References: <1331602756-23567-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331602756-23567-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00433.txt.bz2 On Tue, 13 Mar 2012 02:39:15 +0100, Joel Brobecker wrote: > One way to fix that problem was to lift that limitation, by using > a temporary buffer inside memory_xfer_partial, and then copy the > contents of that buffer into the target buffer after the two steps > are complete. But Pedro felt it was too heavy a hammer. This problem was affecting also gdbserver which I fixed in December: [patch] gdbserver: Fix overlapping memcpy (safe now) http://sourceware.org/ml/gdb-patches/2011-12/msg00057.html I tried now shortly and I cannot reproduce the valgrind errors for GDB with gdbserver with disabled z* packets but according to the code and according to you description it looks as the same problem. Isn't it safer to fix all the cases? Thanks, Jan