From: Joel Brobecker <brobecker@adacore.com>
To: Chris January <chris.january@allinea.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX.
Date: Fri, 09 Mar 2012 19:39:00 -0000 [thread overview]
Message-ID: <20120309193904.GF2853@adacore.com> (raw)
In-Reply-To: <1331217037.2742.10.camel@gumtree>
Chris,
> The address of a Fortran common block may be >INT_MAX. fix_common_block
> should be using CORE_ADDR, not int.
>
> 2012-03-08 Chris January <chris.january@allinea.com>
>
> * stabsread.c (fix_common_block): Change type of valu argument
> to CORE_ADDR.
This change looks correct to me too. Did you run the testsuite to
validate the change, by any chance?
Do you have copyright assignment papers on file with the FSF? If not,
this change is sufficiently small that we can accept it, as well as
your other contribution ("Add another way of setting up [...]").
If you are planning on making other contributions in the future,
we should really get you started on the assignment process - contact
me privately if you'd like to do so.
--
Joel
next prev parent reply other threads:[~2012-03-09 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 14:31 Chris January
2012-03-09 19:39 ` Joel Brobecker [this message]
2012-03-12 8:45 ` Chris January
2012-03-12 15:30 ` Joel Brobecker
2012-03-12 19:30 ` Tom Tromey
2012-03-13 15:17 ` Chris January
2012-03-13 16:50 ` Joel Brobecker
2012-03-12 19:28 ` Tom Tromey
2012-03-08 14:31 Chris January
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309193904.GF2853@adacore.com \
--to=brobecker@adacore.com \
--cc=chris.january@allinea.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox