From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2726 invoked by alias); 9 Mar 2012 19:39:32 -0000 Received: (qmail 2715 invoked by uid 22791); 9 Mar 2012 19:39:31 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 19:39:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 054081C6BB4; Fri, 9 Mar 2012 14:39:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Zh6nBfFAi5sh; Fri, 9 Mar 2012 14:39:13 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C4DE71C6BB3; Fri, 9 Mar 2012 14:39:13 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id ED0EE145615; Fri, 9 Mar 2012 11:39:04 -0800 (PST) Date: Fri, 09 Mar 2012 19:39:00 -0000 From: Joel Brobecker To: Chris January Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX. Message-ID: <20120309193904.GF2853@adacore.com> References: <1331217037.2742.10.camel@gumtree> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331217037.2742.10.camel@gumtree> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00345.txt.bz2 Chris, > The address of a Fortran common block may be >INT_MAX. fix_common_block > should be using CORE_ADDR, not int. > > 2012-03-08 Chris January > > * stabsread.c (fix_common_block): Change type of valu argument > to CORE_ADDR. This change looks correct to me too. Did you run the testsuite to validate the change, by any chance? Do you have copyright assignment papers on file with the FSF? If not, this change is sufficiently small that we can accept it, as well as your other contribution ("Add another way of setting up [...]"). If you are planning on making other contributions in the future, we should really get you started on the assignment process - contact me privately if you'd like to do so. -- Joel