Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] libunwind/ia64: Rename libunwind-frame.[ch]
Date: Thu, 08 Mar 2012 09:15:00 -0000	[thread overview]
Message-ID: <20120308091528.GA14321@host2.jankratochvil.net> (raw)
In-Reply-To: <4F55C2BB.7090205@redhat.com>

On Tue, 06 Mar 2012 08:54:35 +0100, Pedro Alves wrote:
> On 03/04/2012 09:57 PM, Jan Kratochvil wrote:
> > this is just a rename, it breaks the build, but it makes the changes
> > reviewable in [patch 2/2].  It would be checked-in as a single commit.
> 
> BTW, there's a different way to split this so that you don't mix
> the rename with other changes to the same files, and so that
> git log sees through pure file renames without trouble.

'git log' never see a rename while 'git log -M' sees the rename even if those
changes are in single commit as those changes are really very small:

diff --git a/gdb/libunwind-frame.h b/gdb/ia64-libunwind-tdep.h
similarity index 93%
rename from gdb/libunwind-frame.h
rename to gdb/ia64-libunwind-tdep.h
index a6b3c34..221bbd2 100644
--- a/gdb/libunwind-frame.h
+++ b/gdb/ia64-libunwind-tdep.h
@@ -1,4 +1,4 @@
-/* Frame unwinder for frames with libunwind frame information.
+/* Frame unwinder for ia64 frames with libunwind frame information.
[...]

So I do not find a need to use multiple commits into the (CVS) repository.


I was posting it this way so that one can easily apply the series by 'patch'
while still being able to see the changes (in [patch 2/2]).

If one can assume every mailing list user has GIT anyway the repository
absolutely no longer makes sense in CVS.


Thanks,
Jan


  parent reply	other threads:[~2012-03-08  9:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-04 21:58 Jan Kratochvil
2012-03-06  7:54 ` Pedro Alves
2012-03-06  8:43   ` Mark Kettenis
2012-03-06  8:45     ` Jan Kratochvil
2012-03-06  9:00     ` Tristan Gingold
2012-03-06  9:44       ` Pedro Alves
2012-03-06  9:53         ` Jan Kratochvil
2012-03-06 10:35           ` Pedro Alves
2012-03-06 10:48           ` Mark Kettenis
2012-03-06 11:32             ` Jan Kratochvil
2012-03-06 11:43               ` Pedro Alves
2012-03-08  9:15   ` Jan Kratochvil [this message]
2012-03-08 10:40     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120308091528.GA14321@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox