From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29081 invoked by alias); 8 Mar 2012 09:15:51 -0000 Received: (qmail 29072 invoked by uid 22791); 8 Mar 2012 09:15:50 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 09:15:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q289FW7s028192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Mar 2012 04:15:32 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q289FSsM028987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 8 Mar 2012 04:15:31 -0500 Date: Thu, 08 Mar 2012 09:15:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/2] libunwind/ia64: Rename libunwind-frame.[ch] Message-ID: <20120308091528.GA14321@host2.jankratochvil.net> References: <20120304215728.GA2763@host2.jankratochvil.net> <4F55C2BB.7090205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F55C2BB.7090205@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00256.txt.bz2 On Tue, 06 Mar 2012 08:54:35 +0100, Pedro Alves wrote: > On 03/04/2012 09:57 PM, Jan Kratochvil wrote: > > this is just a rename, it breaks the build, but it makes the changes > > reviewable in [patch 2/2]. It would be checked-in as a single commit. > > BTW, there's a different way to split this so that you don't mix > the rename with other changes to the same files, and so that > git log sees through pure file renames without trouble. 'git log' never see a rename while 'git log -M' sees the rename even if those changes are in single commit as those changes are really very small: diff --git a/gdb/libunwind-frame.h b/gdb/ia64-libunwind-tdep.h similarity index 93% rename from gdb/libunwind-frame.h rename to gdb/ia64-libunwind-tdep.h index a6b3c34..221bbd2 100644 --- a/gdb/libunwind-frame.h +++ b/gdb/ia64-libunwind-tdep.h @@ -1,4 +1,4 @@ -/* Frame unwinder for frames with libunwind frame information. +/* Frame unwinder for ia64 frames with libunwind frame information. [...] So I do not find a need to use multiple commits into the (CVS) repository. I was posting it this way so that one can easily apply the series by 'patch' while still being able to see the changes (in [patch 2/2]). If one can assume every mailing list user has GIT anyway the repository absolutely no longer makes sense in CVS. Thanks, Jan