Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Luis Gustavo <luis_gustavo@mentor.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Make AX engine fail gracefully due to unknown types
Date: Wed, 07 Mar 2012 20:22:00 -0000	[thread overview]
Message-ID: <20120307202203.GA5491@host2.jankratochvil.net> (raw)
In-Reply-To: <4F57A77E.307@mentor.com>

On Wed, 07 Mar 2012 19:22:54 +0100, Luis Gustavo wrote:
> +++ HEAD-git/gdb/ax-gdb.c	2012-03-07 14:16:23.846145476 -0300
> @@ -557,8 +557,8 @@ gen_fetch (struct agent_expr *ax, struct
>           pointer (other code's fault), or we're not implementing
>           something we should be (this code's fault).  In any case,
>           it's a bug the user shouldn't see.  */
> -      internal_error (__FILE__, __LINE__,
> -		      _("gen_fetch: bad type code"));
> +      error (_("gen_fetch: Unsupported type code `%s'."),
> +	     TYPE_NAME (type));

I find it OK but here the comment should be updated.


Thanks,
Jan


  parent reply	other threads:[~2012-03-07 20:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 18:23 Luis Gustavo
2012-03-07 18:35 ` Luis Gustavo
2012-03-07 20:22 ` Jan Kratochvil [this message]
2012-03-08 16:44   ` Luis Gustavo
2012-03-08 16:52     ` Jan Kratochvil
2012-03-08 21:09       ` Luis Gustavo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120307202203.GA5491@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis_gustavo@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox