From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88624-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30306 invoked by alias); 7 Mar 2012 20:22:36 -0000
Received: (qmail 30295 invoked by uid 22791); 7 Mar 2012 20:22:32 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Mar 2012 20:22:11 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q27KM7OG021900	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 7 Mar 2012 15:22:07 -0500
Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q27KM4cR010328	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 7 Mar 2012 15:22:06 -0500
Date: Wed, 07 Mar 2012 20:22:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Luis Gustavo <luis_gustavo@mentor.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Make AX engine fail gracefully due to unknown types
Message-ID: <20120307202203.GA5491@host2.jankratochvil.net>
References: <4F57A77E.307@mentor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F57A77E.307@mentor.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00246.txt.bz2

On Wed, 07 Mar 2012 19:22:54 +0100, Luis Gustavo wrote:
> +++ HEAD-git/gdb/ax-gdb.c	2012-03-07 14:16:23.846145476 -0300
> @@ -557,8 +557,8 @@ gen_fetch (struct agent_expr *ax, struct
>           pointer (other code's fault), or we're not implementing
>           something we should be (this code's fault).  In any case,
>           it's a bug the user shouldn't see.  */
> -      internal_error (__FILE__, __LINE__,
> -		      _("gen_fetch: bad type code"));
> +      error (_("gen_fetch: Unsupported type code `%s'."),
> +	     TYPE_NAME (type));

I find it OK but here the comment should be updated.


Thanks,
Jan