Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [patch 2/2] typedef-checking for CU relative vs. absolute offsets [Re: RFC: problem with DW_OP_GNU_deref_type and dwarf's get_base_type callback]
Date: Wed, 07 Mar 2012 19:10:00 -0000	[thread overview]
Message-ID: <20120307190936.GA30591@host2.jankratochvil.net> (raw)
In-Reply-To: <CADPb22SQt9G4skq9LWxKTrivW-d6JRXzWTNupWjFrkWAboJV8A@mail.gmail.com>

On Wed, 07 Mar 2012 19:58:17 +0100, Doug Evans wrote:
> The problem stems from "offset" being ambiguous.
> I'd rather just pick a better (clearer) name and be consistent.

I have to strongly disagree, without automatic checking this bug will creep in
again. Even with testcases it does not get found as they rarely excersise
multiple CUs.

Plus these advanced DWARF features are used only for -O2 -g builds and so bugs
there have low chance to be reported - everyone expects -O2 -g debug info is
not good.


I find the other possibility some static checker instead, to have just some:
typedef unsigned int cu_offset; typedef unsigned int sect_offset;
No idea which static checker can find it.


Thanks,
Jan


  reply	other threads:[~2012-03-07 19:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 22:34 RFC: problem with DW_OP_GNU_deref_type and dwarf's get_base_type callback Joel Brobecker
2012-03-06 20:25 ` Tom Tromey
2012-03-06 23:46   ` Joel Brobecker
2012-03-07 17:10 ` [patch] Fix CU relative vs. absolute offsets [Re: RFC: problem with DW_OP_GNU_deref_type and dwarf's get_base_type callback] Jan Kratochvil
2012-03-07 17:13   ` [patch 2/2] typedef-checking for " Jan Kratochvil
2012-03-07 18:58     ` Doug Evans
2012-03-07 19:10       ` Jan Kratochvil [this message]
2012-03-07 19:29         ` Jan Kratochvil
2012-03-08 21:54       ` Tom Tromey
2012-03-08 21:56         ` Doug Evans
2012-03-07 19:07     ` Joel Brobecker
2012-03-07 19:16       ` Jan Kratochvil
2012-03-08 21:53     ` Tom Tromey
2012-03-09 19:40       ` cu_offset vs. sect_offset field names bikeshedding [Re: [patch 2/2] typedef-checking for CU relative vs. absolute offsets] Jan Kratochvil
2012-03-09 19:52         ` Joel Brobecker
2012-03-19 20:02           ` [commit] [patch 2/2] typedef-checking for CU relative vs. absolute offsets Jan Kratochvil
2012-03-09 19:56         ` cu_offset vs. sect_offset field names bikeshedding [Re: [patch 2/2] typedef-checking for CU relative vs. absolute offsets] Tom Tromey
2012-03-07 18:57   ` [patch] Fix CU relative vs. absolute offsets [Re: RFC: problem with DW_OP_GNU_deref_type and dwarf's get_base_type callback] Joel Brobecker
2012-03-07 19:47     ` Joel Brobecker
2012-03-08 19:40       ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120307190936.GA30591@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox