Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gdb-patches@sourceware.org, Kevin Buettner <kevinb@redhat.com>
Subject: Re: Testsuite regression for annota1.exp and annota3.exp  [Re: [PATCH] [SH] ... can do this signal stuff!]
Date: Tue, 28 Feb 2012 19:43:00 -0000	[thread overview]
Message-ID: <20120228194137.GA947@host2.jankratochvil.net> (raw)
In-Reply-To: <871upe6aj5.fsf@schwinge.name>

On Tue, 28 Feb 2012 20:08:30 +0100, Thomas Schwinge wrote:
> 142db50201b1b1c69ebdc2dcdb1181cde1db3b08 I got the idea of using [concat
> ...] for building gdb_expect_list's third list argument -- it needs to
> expand $main_line, etc.  Any better suggestions (I obviously don't have a
> lot of TCL and/or GDB testcase writing experience), or is this
> acceptable?

I find it OK.

Please edit in your patch:
> +    "Breakpoint.*at.* file .*$srcfile, line $main_line\." \
->
  +    "Breakpoint.*at.* file .*$srcfile, line $main_line\\." \

(as \. is just TCL character . and regex then just gets ., not \.)


I would just write stupid:

gdb_expect_list "break at main" "$gdb_prompt$" [list	\
    "\r\n\032\032post-prompt\r\n"			\
    "Breakpoint 4 at 0x\[0-9a-z\]+: file .*annota3.c, line $main_line.\r\n"]

But fine with me with your / Tom's solution avoiding those backslashes.


Thanks,
Jan


  reply	other threads:[~2012-02-28 19:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 10:03 [PATCH] [SH] ... can do this signal stuff! Thomas Schwinge
2012-02-28 13:43 ` Pedro Alves
2012-02-28 16:05 ` Testsuite regression for annota1.exp and annota3.exp [Re: [PATCH] [SH] ... can do this signal stuff!] Jan Kratochvil
2012-02-28 19:42   ` Thomas Schwinge
2012-02-28 19:43     ` Jan Kratochvil [this message]
2012-02-28 23:27       ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228194137.GA947@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox