From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88297-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31859 invoked by alias); 28 Feb 2012 19:42:01 -0000
Received: (qmail 31848 invoked by uid 22791); 28 Feb 2012 19:42:00 -0000
X-SWARE-Spam-Status: No, hits=-6.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Feb 2012 19:41:46 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1SJfg2V021366	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 28 Feb 2012 14:41:42 -0500
Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1SJfcZK031992	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 28 Feb 2012 14:41:41 -0500
Date: Tue, 28 Feb 2012 19:43:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gdb-patches@sourceware.org, Kevin Buettner <kevinb@redhat.com>
Subject: Re: Testsuite regression for annota1.exp and annota3.exp  [Re: [PATCH] [SH] ... can do this signal stuff!]
Message-ID: <20120228194137.GA947@host2.jankratochvil.net>
References: <874nub5n16.fsf@schwinge.name> <20120228160351.GA12029@host2.jankratochvil.net> <871upe6aj5.fsf@schwinge.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871upe6aj5.fsf@schwinge.name>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00669.txt.bz2

On Tue, 28 Feb 2012 20:08:30 +0100, Thomas Schwinge wrote:
> 142db50201b1b1c69ebdc2dcdb1181cde1db3b08 I got the idea of using [concat
> ...] for building gdb_expect_list's third list argument -- it needs to
> expand $main_line, etc.  Any better suggestions (I obviously don't have a
> lot of TCL and/or GDB testcase writing experience), or is this
> acceptable?

I find it OK.

Please edit in your patch:
> +    "Breakpoint.*at.* file .*$srcfile, line $main_line\." \
->
  +    "Breakpoint.*at.* file .*$srcfile, line $main_line\\." \

(as \. is just TCL character . and regex then just gets ., not \.)


I would just write stupid:

gdb_expect_list "break at main" "$gdb_prompt$" [list	\
    "\r\n\032\032post-prompt\r\n"			\
    "Breakpoint 4 at 0x\[0-9a-z\]+: file .*annota3.c, line $main_line.\r\n"]

But fine with me with your / Tom's solution avoiding those backslashes.


Thanks,
Jan