From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] sim: Update sim_{fetch,store}_register for sh and mn10300
Date: Thu, 16 Feb 2012 23:40:00 -0000 [thread overview]
Message-ID: <20120216163614.01b9f4fd@mesquite.lan> (raw)
In-Reply-To: <201202152354.21507.vapier@gentoo.org>
On Wed, 15 Feb 2012 23:54:20 -0500
Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 15 February 2012 19:13:19 Kevin Buettner wrote:
> > The patch below updates sim_fetch_register for both mn10300 and sh
> > to return the length of the value being fetched instead of -1. For
> > sh, sim_store_register() is changed in a like fashion.
> >
> > This change is necessary due to past changes to remote-sim.c which do
> > more stringent checks of the return value.
> >
> > Comments?
>
> i assume `make sim-check` passes for the sh target, so OK
I ran that test; it does pass.
> > sim/ChangeLog:
> >
> > * sh/interp.c (sim_store_register, sim_fetch_register): Return
> > length, not -1.
>
> note: there is a sim/sh/ChangeLog
Thanks. I've put that entry in sim/sh/ChangeLog.
I've committed this patch. Thanks for the quick approval!
Kevin
prev parent reply other threads:[~2012-02-16 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 0:27 Kevin Buettner
2012-02-16 10:38 ` Mike Frysinger
2012-02-16 23:40 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216163614.01b9f4fd@mesquite.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox