From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18349 invoked by alias); 16 Feb 2012 23:36:32 -0000 Received: (qmail 18276 invoked by uid 22791); 16 Feb 2012 23:36:31 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Feb 2012 23:36:16 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1GNaFg8011435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Feb 2012 18:36:15 -0500 Received: from mesquite.lan (ovpn-113-100.phx2.redhat.com [10.3.113.100]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1GNaFNJ016075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 16 Feb 2012 18:36:15 -0500 Date: Thu, 16 Feb 2012 23:40:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [RFC] sim: Update sim_{fetch,store}_register for sh and mn10300 Message-ID: <20120216163614.01b9f4fd@mesquite.lan> In-Reply-To: <201202152354.21507.vapier@gentoo.org> References: <20120215171319.229a3e1d@mesquite.lan> <201202152354.21507.vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00338.txt.bz2 On Wed, 15 Feb 2012 23:54:20 -0500 Mike Frysinger wrote: > On Wednesday 15 February 2012 19:13:19 Kevin Buettner wrote: > > The patch below updates sim_fetch_register for both mn10300 and sh > > to return the length of the value being fetched instead of -1. For > > sh, sim_store_register() is changed in a like fashion. > > > > This change is necessary due to past changes to remote-sim.c which do > > more stringent checks of the return value. > > > > Comments? > > i assume `make sim-check` passes for the sh target, so OK I ran that test; it does pass. > > sim/ChangeLog: > > > > * sh/interp.c (sim_store_register, sim_fetch_register): Return > > length, not -1. > > note: there is a sim/sh/ChangeLog Thanks. I've put that entry in sim/sh/ChangeLog. I've committed this patch. Thanks for the quick approval! Kevin