Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in
@ 2012-02-14 23:42 Kevin Buettner
  2012-02-15  0:58 ` Stan Shebs
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Kevin Buettner @ 2012-02-14 23:42 UTC (permalink / raw)
  To: gdb-patches

I think I need approval for the NEWS entry.  The rest of it is an RFC.

Is there anything else I forgot?

(Thanks to Pedro for reminding me about ALL_TARGET_OBS.)

Kevin

	* MAINTAINERS: Add rl78 to target ISA section.
	* Makefile.in (ALL_TARGET_OBS): Add rl78-tdep.o.
	(ALLDEPFILES): Add rl78-tdep.c.
	* NEWS: Mention rl78 as a new target.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.475
diff -u -p -r1.475 MAINTAINERS
--- MAINTAINERS	14 Feb 2012 14:42:12 -0000	1.475
+++ MAINTAINERS	14 Feb 2012 22:27:12 -0000
@@ -309,6 +309,8 @@ the native maintainer when resolving ABI
 
 	powerpc		--target=powerpc-eabi ,-Werror
 
+	rl78		--target=rl78-elf ,-Werror
+
 	s390		--target=s390-linux-gnu ,-Werror
 
 	score	--target=score-elf
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1188
diff -u -p -r1.1188 Makefile.in
--- Makefile.in	9 Feb 2012 16:06:43 -0000	1.1188
+++ Makefile.in	14 Feb 2012 22:27:13 -0000
@@ -555,6 +555,7 @@ ALL_TARGET_OBS = \
 	mt-tdep.o \
 	nto-tdep.o \
 	ppc-linux-tdep.o ppcnbsd-tdep.o ppcobsd-tdep.o ppc-sysv-tdep.o \
+	rl78-tdep.o \
 	rs6000-aix-tdep.o rs6000-tdep.o \
 	s390-tdep.o \
 	score-tdep.o \
@@ -1489,6 +1490,7 @@ ALLDEPFILES = \
 	remote-m32r-sdi.c remote-mips.c \
 	remote-sim.c \
 	dcache.c \
+	rl78-tdep.c \
 	rs6000-nat.c rs6000-tdep.c \
 	s390-tdep.c s390-nat.c \
 	score-tdep.c \
Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.487
diff -u -p -r1.487 NEWS
--- NEWS	7 Feb 2012 19:47:15 -0000	1.487
+++ NEWS	14 Feb 2012 22:27:13 -0000
@@ -1,6 +1,10 @@
 		What has changed in GDB?
 	     (Organized release by release)
 
+* New targets
+
+Renesas RL78			rl78-*-elf
+
 *** Changes since GDB 7.4
 
 * Python scripting


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in
  2012-02-14 23:42 [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in Kevin Buettner
@ 2012-02-15  0:58 ` Stan Shebs
  2012-02-15  3:55   ` Kevin Buettner
  2012-02-15  6:48 ` Eli Zaretskii
  2012-02-15 22:56 ` Kevin Buettner
  2 siblings, 1 reply; 5+ messages in thread
From: Stan Shebs @ 2012-02-15  0:58 UTC (permalink / raw)
  To: gdb-patches

On 2/14/12 2:37 PM, Kevin Buettner wrote:
> I think I need approval for the NEWS entry.  The rest of it is an RFC.
>
> diff -u -p -r1.487 NEWS
> --- NEWS	7 Feb 2012 19:47:15 -0000	1.487
> +++ NEWS	14 Feb 2012 22:27:13 -0000
> @@ -1,6 +1,10 @@
>   		What has changed in GDB?
>   	     (Organized release by release)
>
> +* New targets
> +
> +Renesas RL78			rl78-*-elf
> +
>   *** Changes since GDB 7.4
>
>   * Python scripting
>
>

Don't you want your new bit underneath "Changes since GDB 7.4"?

Also, I don't know that there is anything like a standard for this, but 
I tend to like having features that affect more users higher in the NEWS 
section for a release, and the more arcane/specialized additions more 
towards the end of the section; the theory being that we have so many 
new features in each release, and many readers won't actually make it 
all the way through the list. :-)

In any case, your changes are fine.

Stan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in
  2012-02-15  0:58 ` Stan Shebs
@ 2012-02-15  3:55   ` Kevin Buettner
  0 siblings, 0 replies; 5+ messages in thread
From: Kevin Buettner @ 2012-02-15  3:55 UTC (permalink / raw)
  To: gdb-patches

On Tue, 14 Feb 2012 15:42:34 -0800
Stan Shebs <stanshebs@earthlink.net> wrote:

> Don't you want your new bit underneath "Changes since GDB 7.4"?

You're right.  I botched it.

> Also, I don't know that there is anything like a standard for this, but 
> I tend to like having features that affect more users higher in the NEWS 
> section for a release, and the more arcane/specialized additions more 
> towards the end of the section; the theory being that we have so many 
> new features in each release, and many readers won't actually make it 
> all the way through the list. :-)

I agree with this too.

Let's try the NEWS entry over again...

	* NEWS: Mention rl78 as a new target.

Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.487
diff -u -p -r1.487 NEWS
--- NEWS	7 Feb 2012 19:47:15 -0000	1.487
+++ NEWS	15 Feb 2012 00:55:19 -0000
@@ -49,6 +49,10 @@
   ** "catch load" and "catch unload" can be used to stop when a shared
      library is loaded or unloaded, respectively.
 
+* New targets
+
+Renesas RL78			rl78-*-elf
+
 *** Changes in GDB 7.4
 
 * GDB now handles ambiguous linespecs more consistently; the existing


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in
  2012-02-14 23:42 [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in Kevin Buettner
  2012-02-15  0:58 ` Stan Shebs
@ 2012-02-15  6:48 ` Eli Zaretskii
  2012-02-15 22:56 ` Kevin Buettner
  2 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2012-02-15  6:48 UTC (permalink / raw)
  To: Kevin Buettner; +Cc: gdb-patches

> Date: Tue, 14 Feb 2012 15:37:34 -0700
> From: Kevin Buettner <kevinb@redhat.com>
> 
> I think I need approval for the NEWS entry.

You've got it.

Thanks.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in
  2012-02-14 23:42 [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in Kevin Buettner
  2012-02-15  0:58 ` Stan Shebs
  2012-02-15  6:48 ` Eli Zaretskii
@ 2012-02-15 22:56 ` Kevin Buettner
  2 siblings, 0 replies; 5+ messages in thread
From: Kevin Buettner @ 2012-02-15 22:56 UTC (permalink / raw)
  To: gdb-patches

On Tue, 14 Feb 2012 15:37:34 -0700
Kevin Buettner <kevinb@redhat.com> wrote:

> 	* MAINTAINERS: Add rl78 to target ISA section.
> 	* Makefile.in (ALL_TARGET_OBS): Add rl78-tdep.o.
> 	(ALLDEPFILES): Add rl78-tdep.c.
> 	* NEWS: Mention rl78 as a new target.

Committed.

Thanks to Stan for looking it over and Eli for the approval.

Kevin


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-02-15 22:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-14 23:42 [RFA] Add rl78 to NEWS, MAINTAINERS, and Makefile.in Kevin Buettner
2012-02-15  0:58 ` Stan Shebs
2012-02-15  3:55   ` Kevin Buettner
2012-02-15  6:48 ` Eli Zaretskii
2012-02-15 22:56 ` Kevin Buettner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox