From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, asmwarrior <asmwarrior@gmail.com>,
Yao Qi <yao@codesourcery.com>
Subject: Re: [RFA/commit] gdbserver: return ENOSYS if readlink not supported.
Date: Thu, 09 Feb 2012 17:32:00 -0000 [thread overview]
Message-ID: <20120209173212.GC3474@adacore.com> (raw)
In-Reply-To: <4F33F708.2070003@redhat.com>
> > Given that this problem has been lingering for 3 weeks, I've decided
> > to just KISS. This reproduces on the GDBserver side what GDB does
> > when readlink is not supported. Does this look good to you?
>
> Yes, it does. Thanks!
Awesome, thanks! Patch now checked in.
For Eli, I am not discarding his feedback, but in the interest of getting
the build failure out of the way, decided to go for simple. If we'd like
to improve the situation, I think the best approach is to use gnulib's
readlink. But given that this appears to be used on Linux systems only,
this work would be purely accademic at this point. So I think the effort
can be defered for now.
--
Joel
prev parent reply other threads:[~2012-02-09 17:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 3:20 fix build error on MinGW (HAVE_READLINK) undefined asmwarrior
2012-01-27 9:41 ` Eli Zaretskii
2012-01-27 10:28 ` Pedro Alves
2012-01-27 12:22 ` Eli Zaretskii
2012-01-27 12:36 ` Pedro Alves
2012-01-27 12:47 ` Eli Zaretskii
2012-02-03 11:47 ` [RFA/gdbserver] Provide dummy readlink on systems where routine is not available Joel Brobecker
2012-02-03 11:56 ` Joel Brobecker
2012-02-03 12:31 ` Joel Brobecker
2012-02-03 13:11 ` Eli Zaretskii
2012-02-03 13:26 ` Joel Brobecker
2012-02-09 16:32 ` [RFA/commit] gdbserver: return ENOSYS if readlink not supported Joel Brobecker
2012-02-09 16:41 ` Pedro Alves
2012-02-09 17:32 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209173212.GC3474@adacore.com \
--to=brobecker@adacore.com \
--cc=asmwarrior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox