From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12698 invoked by alias); 9 Feb 2012 17:32:37 -0000 Received: (qmail 12688 invoked by uid 22791); 9 Feb 2012 17:32:36 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Feb 2012 17:32:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E28311C6A66; Thu, 9 Feb 2012 12:32:15 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CxTPcJ8EKVOw; Thu, 9 Feb 2012 12:32:15 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 78FC41C6A65; Thu, 9 Feb 2012 12:32:15 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 1A7AA145615; Thu, 9 Feb 2012 21:32:12 +0400 (RET) Date: Thu, 09 Feb 2012 17:32:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org, asmwarrior , Yao Qi Subject: Re: [RFA/commit] gdbserver: return ENOSYS if readlink not supported. Message-ID: <20120209173212.GC3474@adacore.com> References: <4F22760A.2020309@redhat.com> <1328805094-18863-1-git-send-email-brobecker@adacore.com> <4F33F708.2070003@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F33F708.2070003@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00150.txt.bz2 > > Given that this problem has been lingering for 3 weeks, I've decided > > to just KISS. This reproduces on the GDBserver side what GDB does > > when readlink is not supported. Does this look good to you? > > Yes, it does. Thanks! Awesome, thanks! Patch now checked in. For Eli, I am not discarding his feedback, but in the interest of getting the build failure out of the way, decided to go for simple. If we'd like to improve the situation, I think the best approach is to use gnulib's readlink. But given that this appears to be used on Linux systems only, this work would be purely accademic at this point. So I think the effort can be defered for now. -- Joel