Re: [RFA] Linespec tweak (was: Re: [RFA take 3] Allow setting breakpoints on inline functions (PR 10738))

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Mon, 30 Jan 2012 15:03:39 +0100, Gary Benson wrote:
> Attached.  I also commented the return values of another callback used
> internally by iterate_over_all_matching_symtabs, at the very top of
> the patch.
> 
> Ok to commit?

Sorry I wrongly replied on IRC, that symbol_found_callback_ftype should be
used also for struct language_defn->la_iterate_over_symbols and
ada_iterate_over_symbols, this was why I found it useful.


> +/* Callback for iterate_over_all_matching_symtabs.  The callback
> +   will be called once per matching symbol SYM, with DATA being
> +   the argument of the same name that was passed to
> +   iterate_over_all_matching_symtabs.  The callback should return

No reference to iterate_over_all_matching_symtabs anymore here, it is used at
more places now.


> +   nonzero to indicate that iterate_over_all_matching_symtabs should
> +   continue iterating, or zero to indicate that the iteration should
> +   end.  */
[...]

>    if (SYMBOL_CLASS (sym) != LOC_TYPEDEF)
> -    return 1;
> +    return 1; /* Continue iterating. */
Should be:
       return 1; /* Continue iterating.  */

On multiple places.


Otherwise fine with me.


Thanks,
Jan