From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15010 invoked by alias); 30 Jan 2012 14:16:34 -0000 Received: (qmail 14985 invoked by uid 22791); 30 Jan 2012 14:16:32 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jan 2012 14:16:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0UEGJxX020016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Jan 2012 09:16:19 -0500 Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0UEGD8U004082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Mon, 30 Jan 2012 09:16:17 -0500 Date: Mon, 30 Jan 2012 14:31:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: Re: [RFA] Linespec tweak (was: Re: [RFA take 3] Allow setting breakpoints on inline functions (PR 10738)) Message-ID: <20120130141612.GA25851@host2.jankratochvil.net> References: <20120127151034.GA22606@redhat.com> <20120128001638.GA4448@host2.jankratochvil.net> <20120128090724.GA30170@host2.jankratochvil.net> <20120130140339.GB5210@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120130140339.GB5210@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00988.txt.bz2 On Mon, 30 Jan 2012 15:03:39 +0100, Gary Benson wrote: > Attached. I also commented the return values of another callback used > internally by iterate_over_all_matching_symtabs, at the very top of > the patch. > > Ok to commit? Sorry I wrongly replied on IRC, that symbol_found_callback_ftype should be used also for struct language_defn->la_iterate_over_symbols and ada_iterate_over_symbols, this was why I found it useful. > +/* Callback for iterate_over_all_matching_symtabs. The callback > + will be called once per matching symbol SYM, with DATA being > + the argument of the same name that was passed to > + iterate_over_all_matching_symtabs. The callback should return No reference to iterate_over_all_matching_symtabs anymore here, it is used at more places now. > + nonzero to indicate that iterate_over_all_matching_symtabs should > + continue iterating, or zero to indicate that the iteration should > + end. */ [...] > if (SYMBOL_CLASS (sym) != LOC_TYPEDEF) > - return 1; > + return 1; /* Continue iterating. */ Should be: return 1; /* Continue iterating. */ On multiple places. Otherwise fine with me. Thanks, Jan