Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch] Code cleanup: gdbserver: Use ptid_is_pid
@ 2012-01-20 19:54 Jan Kratochvil
  2012-01-20 20:01 ` Pedro Alves
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Kratochvil @ 2012-01-20 19:54 UTC (permalink / raw)
  To: gdb-patches

Hi,

probably obvious.  I will check it in with no response.

No regressions in gdbserver mode on
{x86_64,x86_64-m32,i686}-fedorarawhide-linux-gnu.  The callers look no
null_ptid can be used there.


Thanks,
Jan


gdb/gdbserver/
2012-01-20  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Code cleanup.
	* linux-low.c (linux_wait_for_event_1): Use ptid_is_pid.

--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -1578,8 +1578,7 @@ linux_wait_for_event_1 (ptid_t ptid, int *wstat, int options)
 
   /* Check for a lwp with a pending status.  */
 
-  if (ptid_equal (ptid, minus_one_ptid)
-      || ptid_equal (pid_to_ptid (ptid_get_pid (ptid)), ptid))
+  if (ptid_equal (ptid, minus_one_ptid) || ptid_is_pid (ptid))
     {
       event_child = (struct lwp_info *)
 	find_inferior (&all_lwps, status_pending_p_callback, &ptid);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] Code cleanup: gdbserver: Use ptid_is_pid
  2012-01-20 19:54 [patch] Code cleanup: gdbserver: Use ptid_is_pid Jan Kratochvil
@ 2012-01-20 20:01 ` Pedro Alves
  2012-01-20 21:20   ` [commit] " Jan Kratochvil
  0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2012-01-20 20:01 UTC (permalink / raw)
  To: Jan Kratochvil; +Cc: gdb-patches

On 01/20/2012 07:52 PM, Jan Kratochvil wrote:
> Hi,
> 
> probably obvious.  I will check it in with no response.

It's okay.  Thanks.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [commit] [patch] Code cleanup: gdbserver: Use ptid_is_pid
  2012-01-20 20:01 ` Pedro Alves
@ 2012-01-20 21:20   ` Jan Kratochvil
  0 siblings, 0 replies; 3+ messages in thread
From: Jan Kratochvil @ 2012-01-20 21:20 UTC (permalink / raw)
  To: Pedro Alves; +Cc: gdb-patches

On Fri, 20 Jan 2012 20:57:29 +0100, Pedro Alves wrote:
> It's okay.  Thanks.

Checked in:
	http://sourceware.org/ml/gdb-cvs/2012-01/msg00177.html


Thanks,
Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-20 20:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-20 19:54 [patch] Code cleanup: gdbserver: Use ptid_is_pid Jan Kratochvil
2012-01-20 20:01 ` Pedro Alves
2012-01-20 21:20   ` [commit] " Jan Kratochvil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox