Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com
Subject: Re: [rfc v3][0/6] Remote /proc file access
Date: Wed, 18 Jan 2012 11:46:00 -0000	[thread overview]
Message-ID: <20120118113807.GA31383@adacore.com> (raw)
In-Reply-To: <OF5DB6AADD.80E0AB5F-ONC1257988.006C1C48@de.ibm.com>

> Joel, would you mind re-running the tests on a procfs target
> since this patch does change the procfs.c file, which I cannot
> test ...   Thanks!

I ran the testsuite on mips-irix, and got one real semi-regression:

    info proc^M
    Not supported on this target.^M
    (gdb) FAIL: gdb.base/info-proc.exp: info proc without a process

I think it's just a matter of the output having changed. I couldn't
verify it completely, because I had lost the gdb.log file from the
reference run (they are now split, and I only saved the top one).
If it wasn't intended, I'd still consider this an improvement since
the expected output was:

    No current process: <something like please select one>

I never feel completely confident about runs on mips-irix, because
GDB does not work at all with programs that use threading. AdaCore
has some local changes regarding this feature, but they are very
hacky and would probably not pass a normal review.

I cannot test using the standard testsuite on sparc-solaris. But
I can run our testsuite. So I applied your changes to our own tree,
and ran the testsuite. Found no regression. I think that's an extra
vote of confidence.

-- 
Joel


  parent reply	other threads:[~2012-01-18 11:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-17 19:41 Ulrich Weigand
2012-01-17 20:19 ` Pedro Alves
2012-01-17 20:33   ` Ulrich Weigand
2012-01-18 11:46 ` Joel Brobecker [this message]
2012-01-18 12:09   ` Pedro Alves
2012-01-18 15:33     ` Ulrich Weigand
2012-01-19 10:00       ` Joel Brobecker
2012-01-19 10:01         ` [rfc v4][0/6] Remote /proc file access (Re: [rfc v3][0/6] Remote /proc file access) Ulrich Weigand
2012-01-19 16:03           ` Joel Brobecker
2012-01-20 10:01             ` Joel Brobecker
2012-01-20 10:02               ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118113807.GA31383@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox