From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15555 invoked by alias); 18 Jan 2012 11:38:56 -0000 Received: (qmail 15542 invoked by uid 22791); 18 Jan 2012 11:38:55 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_OC X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jan 2012 11:38:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 237192BB074; Wed, 18 Jan 2012 06:38:41 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id G-8ypGYnL9ZW; Wed, 18 Jan 2012 06:38:41 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 93E722BB273; Wed, 18 Jan 2012 06:38:40 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4479B145615; Wed, 18 Jan 2012 15:38:07 +0400 (RET) Date: Wed, 18 Jan 2012 11:46:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org, palves@redhat.com Subject: Re: [rfc v3][0/6] Remote /proc file access Message-ID: <20120118113807.GA31383@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00664.txt.bz2 > Joel, would you mind re-running the tests on a procfs target > since this patch does change the procfs.c file, which I cannot > test ... Thanks! I ran the testsuite on mips-irix, and got one real semi-regression: info proc^M Not supported on this target.^M (gdb) FAIL: gdb.base/info-proc.exp: info proc without a process I think it's just a matter of the output having changed. I couldn't verify it completely, because I had lost the gdb.log file from the reference run (they are now split, and I only saved the top one). If it wasn't intended, I'd still consider this an improvement since the expected output was: No current process: I never feel completely confident about runs on mips-irix, because GDB does not work at all with programs that use threading. AdaCore has some local changes regarding this feature, but they are very hacky and would probably not pass a normal review. I cannot test using the standard testsuite on sparc-solaris. But I can run our testsuite. So I applied your changes to our own tree, and ran the testsuite. Found no regression. I think that's an extra vote of confidence. -- Joel