[PATCH] gdbserver: install gdbreplay too

[PATCH] gdbserver: install gdbreplay too

[Mike Frysinger]

The gdbreplay binary is pretty useful, so install it by default like we
do with gdbserver already.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2011-12-31  Mike Frysinger  <vapier@gentoo.org>

	* Makefile.in (install): Install gdbreplay into $(bindir).
---
 gdb/gdbserver/Makefile.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
index 01729ce..1ce196a 100644
--- a/gdb/gdbserver/Makefile.in
+++ b/gdb/gdbserver/Makefile.in
@@ -213,6 +213,8 @@ install-only:
 	$(INSTALL_PROGRAM) gdbserver$(EXEEXT) $(DESTDIR)$(bindir)/$$n$(EXEEXT); \
 	$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(man1dir); \
 	$(INSTALL_DATA) $(srcdir)/gdbserver.1 $(DESTDIR)$(man1dir)/$$n.1
+	n=`echo gdbreplay | sed '$(program_transform_name)'`; \
+	$(INSTALL_PROGRAM) gdbreplay$(EXEEXT) $(DESTDIR)$(bindir)/$$n$(EXEEXT); \
 
 uninstall: force
 	n=`echo gdbserver | sed '$(program_transform_name)'`; \
-- 
1.7.6.1

Re: [PATCH] gdbserver: install gdbreplay too

[Joel Brobecker]

> The gdbreplay binary is pretty useful, so install it by default like we
> do with gdbserver already.
>
> 2011-12-31  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* Makefile.in (install): Install gdbreplay into $(bindir).

This seems reasonable to me, but I don't really know the history,
whether this was an oversight or a conscious decision. Let's wait
a little and see what others think...

-- 
Joel

Re: [PATCH] gdbserver: install gdbreplay too

[Jan Kratochvil]

On Sat, 31 Dec 2011 09:58:08 +0100, Mike Frysinger wrote:
> The gdbreplay binary is pretty useful, so install it by default like we
> do with gdbserver already.

If it becomes the standard installation part there would be very useful a man
page.  Similar case is being discussed in:
	Re: [patch] gdb_gcore man/help/install [+doc] #2
	http://sourceware.org/ml/gdb-patches/2011-12/msg00659.html


Thanks,
Jan

Re: [PATCH] gdbserver: install gdbreplay too

[Pedro Alves]

On 12/31/2011 08:58 AM, Mike Frysinger wrote:
> The gdbreplay binary is pretty useful, so install it by default like we
> do with gdbserver already.

I'm ambivalent on this.  This is a gdb developer tool, not something a 
user would use.

>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
>
> 2011-12-31  Mike Frysinger<vapier@gentoo.org>
>
> 	* Makefile.in (install): Install gdbreplay into $(bindir).
> ---
>   gdb/gdbserver/Makefile.in |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
> index 01729ce..1ce196a 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -213,6 +213,8 @@ install-only:
>   	$(INSTALL_PROGRAM) gdbserver$(EXEEXT) $(DESTDIR)$(bindir)/$$n$(EXEEXT); \
>   	$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(man1dir); \
>   	$(INSTALL_DATA) $(srcdir)/gdbserver.1 $(DESTDIR)$(man1dir)/$$n.1
> +	n=`echo gdbreplay | sed '$(program_transform_name)'`; \
> +	$(INSTALL_PROGRAM) gdbreplay$(EXEEXT) $(DESTDIR)$(bindir)/$$n$(EXEEXT); \
>
>   uninstall: force
>   	n=`echo gdbserver | sed '$(program_transform_name)'`; \

Re: [PATCH] gdbserver: install gdbreplay too

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 420 bytes --]

On Monday 02 January 2012 07:46:45 Pedro Alves wrote:
> On 12/31/2011 08:58 AM, Mike Frysinger wrote:
> > The gdbreplay binary is pretty useful, so install it by default like we
> > do with gdbserver already.
> 
> I'm ambivalent on this.  This is a gdb developer tool, not something a
> user would use.

aren't all users just developers in hiding ? ;)

i can drop it if people prefer not to install it
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] gdbserver: install gdbreplay too

[Joel Brobecker]

> aren't all users just developers in hiding ? ;)
> 
> i can drop it if people prefer not to install it

One thing I realized is that there doesn't appear to be any
documentation for that program. So, I looked at the program code,
and it says that it takes a log file of the remote and replays it.
But the documentation seems to also be silent about how to produce
that log file.  How does it work?

-- 
Joel

Re: [PATCH] gdbserver: install gdbreplay too

[Joel Brobecker]

> One thing I realized is that there doesn't appear to be any
> documentation for that program. So, I looked at the program code,
> and it says that it takes a log file of the remote and replays it.
> But the documentation seems to also be silent about how to produce
> that log file.  How does it work?

I found everything I wanted to know in the README file. Not your fault...
It would be nice to fix, one of these days. I've added this item to
the "Project Ideas" list. Someone intimidated by the complexity of
other projects might find this one easier to do...

-- 
Joel

Re: [PATCH] gdbserver: install gdbreplay too

[Pedro Alves]

On 01/03/2012 02:30 AM, Mike Frysinger wrote:
> On Monday 02 January 2012 07:46:45 Pedro Alves wrote:
>> On 12/31/2011 08:58 AM, Mike Frysinger wrote:
>>> The gdbreplay binary is pretty useful, so install it by default like we
>>> do with gdbserver already.
>>
>> I'm ambivalent on this.  This is a gdb developer tool, not something a
>> user would use.
>
> aren't all users just developers in hiding ? ;)

:-)

>
> i can drop it if people prefer not to install it
> -mike

Personally, I don't think it does real users any good.  Also, a "gdbreplay"
works for any target/host.  I mean, you can just build one, and keep it
around for all debugging against all kinds of targets (arm-none-eabi,
x86_64-unknown-linux-gnu etc.), no need to have one binary per toolchain,
like arm-none-eabi-gdbreplay, x86_64-unknown-linux-gnu-gdbreplay, etc. installed.