From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Delete #if 0'd out code in language.c
Date: Thu, 29 Dec 2011 04:11:00 -0000 [thread overview]
Message-ID: <20111229034956.GP23376@adacore.com> (raw)
In-Reply-To: <20111228204834.7E0DC2461C9@ruffy.mtv.corp.google.com>
> 2011-12-28 Doug Evans <dje@google.com>
>
> Delete #if 0'd out code.
> * language.c (binop_result_type): Delete.
> (simple_type, ordered_type, same_type, integral_type): Delete.
> (numeric_type, character_type, string_type, boolean_type): Delete.
> (float_type, structured_type): Delete.
> * language.h: Update.
I wouldn't wait. Any commented out code, especially code that has
been commented out for 10 years, is fair game for instant removal
as an obvious change (IMO). My reason is that it's easy to put back
any part of it should the need arise again.
--
Joel
prev parent reply other threads:[~2011-12-29 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 21:02 Doug Evans
2011-12-29 4:11 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111229034956.GP23376@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox