From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29869 invoked by alias); 29 Dec 2011 03:50:26 -0000 Received: (qmail 29859 invoked by uid 22791); 29 Dec 2011 03:50:24 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Dec 2011 03:50:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 21C4A2BAE4F; Wed, 28 Dec 2011 22:50:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lnpq2olTtVVd; Wed, 28 Dec 2011 22:50:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B1F902BAE40; Wed, 28 Dec 2011 22:50:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0770C145615; Wed, 28 Dec 2011 19:49:56 -0800 (PST) Date: Thu, 29 Dec 2011 04:11:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] Delete #if 0'd out code in language.c Message-ID: <20111229034956.GP23376@adacore.com> References: <20111228204834.7E0DC2461C9@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111228204834.7E0DC2461C9@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00884.txt.bz2 > 2011-12-28 Doug Evans > > Delete #if 0'd out code. > * language.c (binop_result_type): Delete. > (simple_type, ordered_type, same_type, integral_type): Delete. > (numeric_type, character_type, string_type, boolean_type): Delete. > (float_type, structured_type): Delete. > * language.h: Update. I wouldn't wait. Any commented out code, especially code that has been commented out for 10 years, is fair game for instant removal as an obvious change (IMO). My reason is that it's easy to put back any part of it should the need arise again. -- Joel