From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>, Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Add handling for unqualified Ada operators in linespecs
Date: Wed, 21 Dec 2011 07:41:00 -0000 [thread overview]
Message-ID: <20111221073124.GF23376@adacore.com> (raw)
In-Reply-To: <m3liqc1fk2.fsf@fleche.redhat.com>
> Joel> This patch enhances the linespec parser to recognize unqualified
> Joel> operator names in linespecs. This allows the user to insert a breakpoint
> Joel> on operator "+" as follow, for instance:
> Joel> (gdb) break "+"
>
> I think it is fine to allow this.
Thanks! I have committed this patch.
> I wonder whether this requires a documentation change.
Given that from an Ada programer's perpective, there is nothing special
about this name, so I do not think so. I checked the Ada part of the
manual, and it didn't say that we were not supporting these breakpoints.
So I think we're good.
As stated earlier, I am open to further adjustments if it makes
it easier to deal with the quotes... This could prepare the ground
before Keith's patch comes in, rather than after. I just don't know
enough of Keith's patch yet to be sure which approach to take.
--
Joel
prev parent reply other threads:[~2011-12-21 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 21:24 Joel Brobecker
2011-12-16 19:32 ` Tom Tromey
2011-12-16 19:33 ` Doug Evans
2011-12-16 20:09 ` Keith Seitz
2011-12-16 20:35 ` Tom Tromey
2011-12-17 14:55 ` Joel Brobecker
2011-12-20 15:30 ` Tom Tromey
2011-12-21 6:52 ` Joel Brobecker
2011-12-21 7:41 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221073124.GF23376@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox