Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Add handling for unqualified Ada operators in linespecs
Date: Sat, 17 Dec 2011 14:55:00 -0000	[thread overview]
Message-ID: <20111217144524.GZ21915@adacore.com> (raw)
In-Reply-To: <m3liqc1fk2.fsf@fleche.redhat.com>

Hi Tom

Thanks for the review!

> I think we should continue trying to look at solutions to linespec and
> symbol table problems in as language-independent a way as possible.
> And, if we can't be language-independent, we should endeavor to have
> clean code; the current stuff is still a big mess.

I agree. I haven't had much time to think about this, but I think
it might be quite a challenging project. I need to get up to speed
on Keith's project...

> Joel> +  p = *argptr;
> Joel> +  if (p[0] == '"'
> 
> Why only double quotes?

Because the double quotes are part of the operator name... Eg:

    function "+" (A, B: My_Type) return My_Type;

And if we wanted to be pedantic, the debugger should also accept:

    (gdb) break '"+"'

By comparison, '+' is an entirely different thing (the character +),
and thus breaking on '+' should be rejected.

That being said, if it helps Keith's work to treat them similarly,
then I don't mind being a little approximate here, and treat both
quote characters as the equivalent for linespec purposes. I doubt
that any Ada programer would ever write...

    (gdb) break '+'

... and if that were the case, that he'd complain much about it
inserting a breakpoint on operator "+".

-- 
Joel


  parent reply	other threads:[~2011-12-17 14:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 21:24 Joel Brobecker
2011-12-16 19:32 ` Tom Tromey
2011-12-16 19:33   ` Doug Evans
2011-12-16 20:09   ` Keith Seitz
2011-12-16 20:35     ` Tom Tromey
2011-12-17 14:55   ` Joel Brobecker [this message]
2011-12-20 15:30     ` Tom Tromey
2011-12-21  6:52       ` Joel Brobecker
2011-12-21  7:41   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111217144524.GZ21915@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox