From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Use symbol search name in expand_symtabs_matching_via_partial...
Date: Tue, 13 Dec 2011 21:10:00 -0000 [thread overview]
Message-ID: <20111213204504.GA7129@host2.jankratochvil.net> (raw)
In-Reply-To: <1323808430-18660-1-git-send-email-brobecker@adacore.com>
On Tue, 13 Dec 2011 21:33:50 +0100, Joel Brobecker wrote:
> In C++, that does not make a difference, but it does in
> Ada, because Ada searches using the symbol encoded name...
That is more your Ada decision then...
> --- a/gdb/psymtab.c
> +++ b/gdb/psymtab.c
> @@ -1305,7 +1305,7 @@ expand_symtabs_matching_via_partial
> || (kind == TYPES_DOMAIN
> && SYMBOL_CLASS (*psym) == LOC_TYPEDEF))
> && (*name_matcher) (current_language,
> - SYMBOL_NATURAL_NAME (*psym), data))
> + SYMBOL_SEARCH_NAME (*psym), data))
It will need the same change for .gdb_index in write_psymbols.
It would also mean .gdb_index version should be increased and backward
compatibility implemented although IMHO it can be ignored for Ada, not sure if
Ada users deploy .gdb_index.
Thanks,
Jan
next prev parent reply other threads:[~2011-12-13 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 20:45 Joel Brobecker
2011-12-13 21:10 ` Jan Kratochvil [this message]
2011-12-13 21:30 ` Joel Brobecker
2011-12-13 21:33 ` Jan Kratochvil
2011-12-14 0:18 ` Joel Brobecker
2011-12-21 9:30 ` Joel Brobecker
2011-12-20 15:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213204504.GA7129@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox